901646 - New makes showing up on homepage as featured!!

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Jacob [:Jacob]]

Similarly to Bug 901638 which is affecting the /teach page, when you hit the Load More button on the homepage, it's loading in a ton of recently saved makes that aren't supposed to be there!

Comment 1

[Kat Braybrooke [:codekat]]

yeah, this is a massive issue. had thought the dev team fixed it, but looks like not. we discussed getting rid of the 'load more' feature on frontpage entirely - i'd still say that's a good idea.

Comment 2

[Chris DeCairos (:cade)]

I can reproduce this bug locally. I'm seeing an incorrect query being run:

`GET /api/20130724/make/search?limit=12&sortByField=createdAt,desc&page=2&tagPrefix={!}webmaker:p`

The above request doesn't specify that it needs the webamker:recommended tag, which is why we're seeing what we're seeing.

I'm still trying to locate the origin of it.

Comment 3

[Chris DeCairos (:cade)]

I've got a fix incoming for webmaker.org

Comment 4

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker.org/pull/316

Kate, I'm not sure if this is the right way to fix the problem, and you know this area of the code better than I. Does this look right, or am I breaking the homepage / teach page search?

Comment 5

[inactivate account for kate]

Should be fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=901638