nsIHelperAppLauncher may need IID revved

RESOLVED WONTFIX

Status

()

Firefox
General
RESOLVED WONTFIX
4 years ago
4 years ago

People

(Reporter: bajaj, Assigned: mmc)

Tracking

24 Branch
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
In the process of identifying https://bugzilla.mozilla.org/show_bug.cgi?id=901590, we found this may need IID revved.

Based on my lookup in hg looks like this file was last touched due to :

% hg log ./uriloader/exthandler/nsIExternalHelperAppService.idl
changeset:   145428:b6cce1e41253
parent:      145425:ca43cd65708b
user:        Monica Chew <mmc@mozilla.com>
date:        Mon May 27 18:33:39 2013 -0700
summary:     Move execution from nsExternalAppHandler to nsDownload (b=858234, r=paolo)

changeset:   145114:1623ffc069a0
user:        Ryan VanderMeulen <ryanvm@gmail.com>
date:        Fri May 31 16:06:10 2013 -0400
summary:     Backed out changeset 019382e24635 (bug 858234) for Linux mochitest-5 leaks.

changeset:   145097:019382e24635
user:        Monica Chew <mmc@mozilla.com>
date:        Mon May 27 18:33:39 2013 -0700
summary:     Move execution from nsExternalAppHandler to nsDownload (b=858234, r=paolo)


Hence ccing folks related who can help.

Please note this needs to be resolved before firefox 24 Beta1 goes to build today.In case this is a false alarm feel free to resolve invalid.The existing script we use may include cases for comments or other false positives.
(Reporter)

Updated

4 years ago
Blocks: 901590
Hello bajaj,

That changeset removed closeProgressWindow from the nsIHelperAppLauncher interface.

The download manager has a new UI, and there is no longer a progress window. There are no native callers to closeProgressWindow, I can't think of a legitimate reason for an addon to call it, so I don't think it's worth revving the version number. Many addons that touch downloads will have to be modified anyway, and that discussion is going on on firefox-dev.

Thanks,
Monica
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.