901722 - Support component alpha layers with d3d11 compositor

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nick Cameron [:nrc]]

Requires making Azure and component alpha work together in ThebesLayerBuffer. Also we need to not have component alpha for Metro.

Comment 1

[Nick Cameron [:nrc]]

Attachment: add a component alpha pref

Comment 2

[Nick Cameron [:nrc]]

Attachment: component alpha for d3d11 compositor

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 786760 [details] [diff] [review]
component alpha for d3d11 compositor

Review of attachment 786760 [details] [diff] [review]:
-----------------------------------------------------------------

D3D10 should use a single pass and use DualOutput blending. See also the current D3D10 code. This requires a little adjustment to the LayerManagerComposite, obviously.

We should also actively investigate dropping component alpha in all the hard cases. (Or maybe everywhere as IE has done)

Comment 4

[Nick Cameron [:nrc]]

Attachment: on pass component alpha

Comment 5

[Bas Schouten (:bas.schouten)]

Comment on attachment 787224 [details] [diff] [review]
on pass component alpha

Review of attachment 787224 [details] [diff] [review]:
-----------------------------------------------------------------

There we go!

::: gfx/layers/d3d9/CompositorD3D9.cpp
@@ -376,5 @@
>        device()->SetTexture(0, sourceOnBlack->GetD3D9Texture());
>        device()->SetTexture(1, sourceOnWhite->GetD3D9Texture());
>        device()->SetRenderState(D3DRS_SRCBLEND, D3DBLEND_ZERO);
>        device()->SetRenderState(D3DRS_DESTBLEND, D3DBLEND_INVSRCCOLOR);
> -      device()->SetRenderState(D3DRS_SEPARATEALPHABLENDENABLE, TRUE);

Not sure why this particular change is in this patch, probably shouldn't be :-).

Comment 6

[Nick Cameron [:nrc]]

(In reply to Bas Schouten (:bas.schouten) from comment #5)
> Comment on attachment 787224 [details] [diff] [review]
> on pass component alpha
> 
> Review of attachment 787224 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> There we go!
> 
> ::: gfx/layers/d3d9/CompositorD3D9.cpp
> @@ -376,5 @@
> >        device()->SetTexture(0, sourceOnBlack->GetD3D9Texture());
> >        device()->SetTexture(1, sourceOnWhite->GetD3D9Texture());
> >        device()->SetRenderState(D3DRS_SRCBLEND, D3DBLEND_ZERO);
> >        device()->SetRenderState(D3DRS_DESTBLEND, D3DBLEND_INVSRCCOLOR);
> > -      device()->SetRenderState(D3DRS_SEPARATEALPHABLENDENABLE, TRUE);
> 
> Not sure why this particular change is in this patch, probably shouldn't be
> :-).

Oh, they were just things I noticed were wrong with the d3d9 compositor whilst looking at blend modes. I'll pull them out into another patch.

Comment 7

[Nick Cameron [:nrc]]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=66dadb3e49f9

Comment 8

[Nick Cameron [:nrc]]

Attachment: part 1 - one pass component alpha

Splitting the previous patch into three. Carrying r=Bas for all patches.

Comment 9

[Nick Cameron [:nrc]]

Attachment: part 2 - generated files

Comment 10

[Nick Cameron [:nrc]]

Attachment: part 3 - changes to d3d9 compositor I noticed along the way

Comment 11

[Nick Cameron [:nrc]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0274b4c2499
https://hg.mozilla.org/integration/mozilla-inbound/rev/198e81ab1bb9
https://hg.mozilla.org/integration/mozilla-inbound/rev/00d371b69457
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8f82c911f6

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c0274b4c2499
https://hg.mozilla.org/mozilla-central/rev/198e81ab1bb9
https://hg.mozilla.org/mozilla-central/rev/00d371b69457
https://hg.mozilla.org/mozilla-central/rev/8d8f82c911f6