Closed Bug 901757 Opened 8 years ago Closed 8 years ago

Create files with correct permissions (0644)

Categories

(Firefox Graveyard :: Web Apps, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file, 1 obsolete file)

Creating them with 0600 caused some problems on Mac.
FWIW I learned the other day that there's a helper const for 0644: FileUtils.PERMS_FILE

There's also FileUtils.PERMS_DIRECTORY that we might investigate if we should be using it
OS: Linux → Mac OS X
Hardware: x86_64 → All
(In reply to :Felipe Gomes from comment #1)
> FWIW I learned the other day that there's a helper const for 0644:
> FileUtils.PERMS_FILE
> 
> There's also FileUtils.PERMS_DIRECTORY that we might investigate if we
> should be using it

Thanks! I'll use them when I'll make changes to WebappsInstaller.jsm.
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attached patch fix_mac_permissions (obsolete) — Splinter Review
Attachment #786073 - Flags: review?(felipc)
Comment on attachment 786073 [details] [diff] [review]
fix_mac_permissions

Review of attachment 786073 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/webapps/WebappsInstaller.jsm
@@ +958,5 @@
>   * @param aFile     the nsIFile to write to
>   * @param aData     a string with the data to be written
>   */
>  function writeToFile(aFile, aData) {
> +  Task.spawn(function() {

just return the promise to keep it as before
Attachment #786073 - Flags: review?(felipc) → review+
Carrying r+.
Attachment #786073 - Attachment is obsolete: true
Attachment #787620 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e50cae680d8c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.