Closed Bug 901761 Opened 7 years ago Closed 7 years ago

PJS: Cleanup MNewPar and support CreateThisWithTemplate

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: dbonetta, Assigned: shu)

References

Details

Attachments

(2 files)

The CreateThisWithTemplate MIR is not supported by the PJS engine.
Blocks: PJS
Assignee: general → shu
Summary: PJS: CreateThisWithTemplate → PJS: Cleanup MNewPar and support CreateThisWithTemplate
No need to get slice from TLS, we always have the slice in a register already.
Attachment #810364 - Flags: review?(nmatsakis)
Attachment #810365 - Flags: review?(nmatsakis)
Comment on attachment 810364 [details] [diff] [review]
Part 1: Pass slice register to OutOfLineNewGCThingPar

Review of attachment 810364 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/CodeGenerator.cpp
@@ +3297,5 @@
>      // returns NULL, we bail.  If returns non-NULL, we rejoin the
>      // original instruction.
> +    Register out = ool->objReg;
> +
> +    saveVolatile(out);

Nice, I didn't know about this.
Attachment #810364 - Flags: review?(nmatsakis) → review+
Attachment #810365 - Flags: review?(nmatsakis) → review+
Requested fuzz for rolled up patch of this bug + bug 903193 in bug 903193.
Depends on: 923314
https://hg.mozilla.org/mozilla-central/rev/012a1f3e3144
https://hg.mozilla.org/mozilla-central/rev/b27e658c9d2d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Depends on: 925548
You need to log in before you can comment on or make changes to this bug.