Closed Bug 901773 Opened 9 years ago Closed 9 years ago

Two GK_ATOM's with "_moz-type"

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: martijn.martijn, Assigned: ehsan.akhgari)

References

()

Details

Attachments

(1 file)

(not sure if this is a bug, but it seems like it to me)
In the source, I'm seeing 2 times GK_ATOM to refer to "_moz-type". It seems to me, ideally, we would only have one of these.

http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsGkAtomList.h#38
 GK_ATOM(moztype, "_moz-type")

http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsGkAtomList.h#52
 GK_ATOM(_moz_type, "_moz-type")
Attached patch Patch (v1)Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #788321 - Flags: review?(khuey)
Comment on attachment 788321 [details] [diff] [review]
Patch (v1)

Review of attachment 788321 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder if it's possible to test this somehow.
Attachment #788321 - Flags: review?(khuey) → review+
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2)
> Comment on attachment 788321 [details] [diff] [review]
> Patch (v1)
> 
> Review of attachment 788321 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I wonder if it's possible to test this somehow.

Should be possible to write a C++ test for it, where you try to detect duplicates.  You can #include "nsGkAtomList.h" for the win.  Feel free to file a bug and assign it to me if that doesn't make sense.
https://hg.mozilla.org/mozilla-central/rev/ea854a4e9e95
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.