901773 - Two GK_ATOM's with "_moz-type"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Martijn Wargers (dead)]

(not sure if this is a bug, but it seems like it to me)
In the source, I'm seeing 2 times GK_ATOM to refer to "_moz-type". It seems to me, ideally, we would only have one of these.

http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsGkAtomList.h#38
 GK_ATOM(moztype, "_moz-type")

http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsGkAtomList.h#52
 GK_ATOM(_moz_type, "_moz-type")

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 788321 [details] [diff] [review]
Patch (v1)

Review of attachment 788321 [details] [diff] [review]:
-----------------------------------------------------------------

I wonder if it's possible to test this somehow.

Comment 3

[(no longer active)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #2)
> Comment on attachment 788321 [details] [diff] [review]
> Patch (v1)
> 
> Review of attachment 788321 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I wonder if it's possible to test this somehow.

Should be possible to write a C++ test for it, where you try to detect duplicates.  You can #include "nsGkAtomList.h" for the win.  Feel free to file a bug and assign it to me if that doesn't make sense.

Comment 4

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea854a4e9e95

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea854a4e9e95