901776 - Update isElementDisplayed atom to handle hidden attribute

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[David Burns :automatedtester]

The hidden attribute in html5 affects the visibility, this has been updated in the webdriver spec and in the atoms

Comment 1

[David Burns :automatedtester]

desktop try is green https://hg.mozilla.org/try/rev/eb991a908904

Comment 2

[David Burns :automatedtester]

Attachment: bug901776.patch

Comment 3

[David Burns :automatedtester]

try is green

https://tbpl.mozilla.org/?tree=Try&rev=dfa00b870a79
https://tbpl.mozilla.org/?tree=Try&rev=14d91ecb8b67

Comment 4

[David Burns :automatedtester]

landed on https://hg.mozilla.org/integration/mozilla-inbound/rev/3c3df71ac20a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3c3df71ac20a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/0c8931d85f0a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/0c8931d85f0a

Comment 8

[Martijn Wargers (dead)]

testing/marionette/atoms/atoms.js is almost an unreadable blob of javascript. I wonder how you are able to patch it.

Comment 9

[Martijn Wargers (dead)]

I wonder because I wonder if opacity:0 is considered isElementDisplayed or not.

Comment 10

[David Burns :automatedtester]

The code is "compiled" from the Selenium project. Elements with Opacity:0 should not be visible.