901783 - Bring some user profile functionality back for app reviewers

Status: RESOLVED FIXED

(Marketplace Graveyard :: Admin Tools, defect, P4)

Description

[Lisa Brewster [:adora]]

Users I tried:
https://marketplace.firefox.com/users/edit/6194949
https://marketplace.firefox.com/users/edit/6420343
https://marketplace.firefox.com/users/edit/9990856

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Per UX we removed profiles a long time ago. What kind of actions would you like to be able to take when managing a given user? We can extend the functionality of the Lookup Tool.

Comment 2

[Lisa Brewster [:adora]]

Ahh, right.  I was in a rush and forgot step 2 of adding a user to a group. (For reference, current process is to get the number at the end of the url above and then enter it on the Configure Groups page.)

Eventually, app review needs some sort of profile functionality back to look up developers (get contact info, list all apps by this developer, etc) and app reviewers (contact info, review history, group membership, a free text notes field would be nice).  We've got about 20 reviewers right now, and it's becoming a challenge to keep track of who's who.

So now this is a feature request, not a bug.

Comment 3

[Andrew Williamson [:eviljeff]]

Where did you get those links from Lisa?  Afaik they all got removed a long time ago too.

Comment 4

[Andrew Williamson [:eviljeff]]

(In reply to Lisa Brewster [:adora] from comment #2)
> Ahh, right.  I was in a rush and forgot step 2 of adding a user to a group.
> (For reference, current process is to get the number at the end of the url
> above and then enter it on the Configure Groups page.)

you can use the lookup tool

> Eventually, app review needs some sort of profile functionality back to look
> up developers (get contact info, list all apps by this developer, etc) 

in the lookup tool now

> and app reviewers (contact info, review history, group membership, a free text
> notes field would be nice).  We've got about 20 reviewers right now, and
> it's becoming a challenge to keep track of who's who.

contact info (email address) and group membership is already in the lookup tool.  Review history could be a link to a log search.  Free text field I don't get though.

> So now this is a feature request, not a bug.

The only thing I think we need generally for Managing users is the Delete button to remove spammers.

Comment 5

[Bram Pitoyo [:bram]]

Can you give me the permission to log into the Reviewer Tools and see the lookup tool in action? I seem to have lost my access.

(In reply to Lisa Brewster [:adora] from comment #2)
> […] a free text notes field would be nice

Would the text field be used for note-taking amongst reviewers, or for sending a generic message to developers?

If the former, can reviewers see each other’s notes, or is every note specific to every reviewer? (Ie. how would the permission model works)? If the latter, can we use the existing review mechanism to deliver these notes?

Comment 6

[Andrew Williamson [:eviljeff]]

(In reply to Bram Pitoyo [:bram] from comment #5)
> Can you give me the permission to log into the Reviewer Tools and see the
> lookup tool in action? I seem to have lost my access.

done

> (In reply to Lisa Brewster [:adora] from comment #2)
> > […] a free text notes field would be nice
> 
> Would the text field be used for note-taking amongst reviewers, or for
> sending a generic message to developers?
> 
> If the former, can reviewers see each other’s notes, or is every note
> specific to every reviewer? (Ie. how would the permission model works)? If
> the latter, can we use the existing review mechanism to deliver these notes?

Neither of those (I believe).  Its a free text field attached to the user profile.  I'm not sure what Lisa intended it be used for exactly

Comment 7

[Rob Hudson [:robhudson]]

It's not very clear from the conversation. What was the agreement on what's needed for this bug?

Comment 8

[Andrew Williamson [:eviljeff]]

At the very least we need a way to delete users.

Potentially change their display name;email address;region also (everything they can do)

Lisa can speak to the free text field thing she wanted.

Comment 9

[Davor Spasovski [:spasovski]]

This probably belongs in admin tools

Comment 10

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/pull/1150

Comment 11

[Kevin Ngo [:ngoke]]

Merged the ability to delete users.

Is that all this bug needs, or do we need a free text field? Would that just be a memo about the user?

Comment 12

[Kevin Ngo [:ngoke]]

Closing for now, can reopen or make new bug for additional feature requests.