897874 Followup: [Notification] horizontally scrollable with many CB messages

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alive, Assigned: hanj.kim25)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Details

(Whiteboard: [TD-68830] [LeoVB+] QARegressExclude)

Attachments

(1 attachment)

198 bytes, text/html
alive
: review+
Details
See https://bugzilla.mozilla.org/show_bug.cgi?id=897874#c12

Leo found the root cause of CB message notification UI malfunction.

+++ This bug was initially created as a clone of Bug #897874 +++

When there are many CB messages on notification panel, 
the notification panel becomes horizontally scrollable.

The notification item was swiped away to get deleted, however 
the notification panel scrolled horizontally.

It was reported that this issue is not reproducible with SMS, but is reproducible with CB messages.
Leo could you revise the patch according to https://bugzilla.mozilla.org/show_bug.cgi?id=897874#c14 ?
Flags: needinfo?(hanj.kim25)
(Assignee)

Comment 2

5 years ago
(In reply to Alive Kuo [:alive] from comment #1)
> Leo could you revise the patch according to
> https://bugzilla.mozilla.org/show_bug.cgi?id=897874#c14 ?

Yes, I plan to work on it sometime this week.
Flags: needinfo?(hanj.kim25)
status-b2g18: fixed → ---
Whiteboard: [TD-68830] [LeoVB+] → [TD-68830]
Bruce,

Can you please help test this bug? This requires cell broadcast testing.

Thanks!!
status-b2g18: --- → fixed
Flags: needinfo?(bweng)
Keywords: qawanted
Whiteboard: [TD-68830] → [TD-68830] [LeoVB+]
Per comment 2 assign to hanj.kim25@gmail.com
Assignee: alive → hanj.kim25

Comment 5

5 years ago
Hi Preeti,

To test CBS, we need emulator but we do not have one. After checked with Wayne, we would like to request Leo to verify the fix. 

Thanks.
Flags: needinfo?(bweng) → needinfo?(leo.bugzilla.gaia)
Triage - leo partner will take this as follow up to bug 897874.

Partner will also feedback test outcome on this.
blocking-b2g: leo? → leo+
dear. hanjun
please let us know the result with this patch.
Flags: needinfo?(leo.bugzilla.gaia) → needinfo?(hanj.kim25)

Updated

5 years ago
Whiteboard: [TD-68830] [LeoVB+] → [TD-68830] [LeoVB+] QARegressExclude

Comment 8

5 years ago
Created attachment 789941 [details]
Pull request url

Sorry for the delay. Here's the pulll request. 
Please also uplift this to v1-train.
Thanks.
Attachment #789941 - Flags: review?(alive)
Flags: needinfo?(hanj.kim25)
Comment on attachment 789941 [details]
Pull request url

r=me, thanks!
Attachment #789941 - Flags: review?(alive) → review+
master
https://github.com/mozilla-b2g/gaia/commit/1aa549b40d714e43846102a5a8b2c996f6493fdf
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-b2g18: fixed → affected
Resolution: --- → FIXED
Keywords: qawanted
Uplifted 1aa549b40d714e43846102a5a8b2c996f6493fdf to:
v1-train: 0f1f1ab0ab31a1df8a780baa048b5e7b2854205d
status-b2g18: affected → fixed
v1.1.0hd: 0f1f1ab0ab31a1df8a780baa048b5e7b2854205d
status-b2g-v1.1hd: --- → fixed
You need to log in before you can comment on or make changes to this bug.