901806 - --enable-metro should be NIGHTLY_BUILD only

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

+++ This bug was initially created as a clone of Bug #856823 +++

The poor folks doing tree management need to change code when Nightly becomes Aurora in order to disable Metro. We should relieve them of this burden by keying --enable-metro to the NIGHTLY_BUILD flag.

Comment 1

[Mike Hommey [:glandium]]

Here's the problem: NIGHTLY_BUILD is available *in* configure, --enable-metro is *passed to* configure, via mozconfig.

Comment 2

[Mike Hommey [:glandium]]

(and --enable-metro is probably not something we'd like to enable on all m-c windows developers).

Comment 3

[Matt Brubeck (:mbrubeck)]

We will want to make --enable-metro the default on m-c eventually, since it's what we're shipping in Nightly and eventually plan to ship in a release.  I think the main reason we haven't is that it adds some build prerequisites and does not compile out-of-the-box with Visual Studio Express.  This isn't well documented/tested but there are some notes at:
https://wiki.mozilla.org/Firefox/Windows_8_Integration#Building_Locally

Comment 4

[Jim Mathies [:jimm]]

We're currently planning on rolling out with 26. :) resolve wontfix?

Comment 5

[Gregory Szorc [:gps]]

Works for me.

We should consider exposing NIGHTLY_BUILD and other tree variables to mozconfig such that they can influence configure arguments. Another time.