Closed Bug 901821 Opened 12 years ago Closed 12 years ago

Clicking button in error pages is broken

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox23+ affected, firefox24+ verified, firefox25+ verified, firefox26+ verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 26
Tracking Flags:
Tracking Status
firefox23 + affected
firefox24 + verified
firefox25 + verified
firefox26 + verified

People

(Reporter: wesj, Assigned: wesj)

References

Details

(Keywords: regression)

Attachments

(1 file)

Patch
1.37 KB, patch
mfinkle
: review+
bajaj
: approval-mozilla-aurora+
bajaj
: approval-mozilla-beta+
lsblakk
: approval-mozilla-release-
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review
While retheming I noticed that clicking buttons on about:certerror or about:blocked seemed broken.
Attachment #786126 - Attachment is patch: true
Attachment #786126 - Flags: review?(mark.finkle)
Attachment #786126 - Flags: review?(mark.finkle) → review+
Uplift to aurora and beta?
Can we add tests for these?
Comment on attachment 786126 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Bug 850435 - Malware/phishing UI Telmetry does not separately measure iframes (sadly, not reviewed by a mobile peer...) User impact if declined: Clicking buttons in error pages doesn't work Testing completed (on m-c, etc.): Landed on mc today Risk to taking this patch (and alternatives if risky): Very low risk. Small patch. Just changes a variable name to be the correct one. String or IDL/UUID changes made by this patch: None.
Attachment #786126 - Flags: approval-mozilla-beta?
Attachment #786126 - Flags: approval-mozilla-aurora?
Blocks: 850435
This also affects release, and is a tiny fix for a pretty serious regression I think. If we do any dot releases, I wonder if we'd take it there?
Comment on attachment 786126 [details] [diff] [review] Patch I'll nom this for release too. I think it'd be a good ride-along.
Attachment #786126 - Flags: approval-mozilla-release?
Will add this to the list for potential ride-along in a 23.0.1 -- tracking for other branches to make sure we land this regression fix.
status-firefox23: --- → affected
status-firefox24: --- → affected
status-firefox25: --- → affected
status-firefox26: --- → affected
tracking-firefox23: ? → +
tracking-firefox24: --- → +
tracking-firefox25: --- → +
tracking-firefox26: --- → +
Keywords: regression
https://hg.mozilla.org/mozilla-central/rev/b43afcd4e347
Assignee: nobody → wjohnston
Status: NEW → RESOLVED
Closed: 12 years ago
status-firefox26: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Attachment #786126 - Flags: approval-mozilla-beta?
Attachment #786126 - Flags: approval-mozilla-beta+
Attachment #786126 - Flags: approval-mozilla-aurora?
Attachment #786126 - Flags: approval-mozilla-aurora+
Comment on attachment 786126 [details] [diff] [review] Patch We don't have a driver for a mobile respin at this point, minusing for m-r branch, this can ship with FF24.
Attachment #786126 - Flags: approval-mozilla-release? → approval-mozilla-release-
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: