Closed Bug 901862 Opened 9 years ago Closed 9 years ago

[Test][System] Unit test for Utility Tray

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Other
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gasolin, Assigned: chsienlee)

References

Details

Attachments

(1 file)

192 bytes, text/html
jlee
: review+
Details
Add unittest to system utility tray
Assignee: nobody → chsienlee
Blocks: 887626
Attached file 11371.html
Comment on attachment 786210 [details]
11371.html

You should set review flag.
Attachment #786210 - Flags: review?(alive)
I've leave some feedback in github, please check it.
Comment on attachment 786210 [details]
11371.html

Please modify per github comments and offline discussion, and request review again, thanks.
Attachment #786210 - Flags: review?(alive)
Flags: sec-review?
You set the wrong flag.
Comment on attachment 786210 [details]
11371.html

Nearly done, please see github comments before merging.
r=alive. Cong first bug!
Attachment #786210 - Flags: review+
Flags: sec-review?
Attachment #786210 - Flags: review+ → review?(alive)
Attachment #786210 - Flags: review?(alive) → review+
merged in gaia-master https://github.com/mozilla-b2g/gaia/commit/babef9d8030b62564e9ac1ce4d11871cc8a4495c

Thanks jason, congrats for your first commit!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.