Closed
Bug 901862
Opened 11 years ago
Closed 11 years ago
[Test][System] Unit test for Utility Tray
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gasolin, Assigned: chsienlee)
References
Details
Attachments
(1 file)
Add unittest to system utility tray
|
||
Comment 2•11 years ago
|
||
Comment on attachment 786210 [details]
11371.html
You should set review flag.
Attachment #786210 -
Flags: review?(alive)
|
Reporter | |
Comment 3•11 years ago
|
||
I've leave some feedback in github, please check it.
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 786210 [details]
11371.html
Please modify per github comments and offline discussion, and request review again, thanks.
Attachment #786210 -
Flags: review?(alive)
|
|
||
Comment 5•11 years ago
|
||
You set the wrong flag.
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 786210 [details]
11371.html
Nearly done, please see github comments before merging.
r=alive. Cong first bug!
Attachment #786210 -
Flags: review+
|
|
||
Updated•11 years ago
|
Flags: sec-review?
Attachment #786210 -
Flags: review+ → review?(alive)
Attachment #786210 -
Flags: review?(alive) → review+
|
|
Reporter | |
Comment 7•11 years ago
|
||
merged in gaia-master https://github.com/mozilla-b2g/gaia/commit/babef9d8030b62564e9ac1ce4d11871cc8a4495c
Thanks jason, congrats for your first commit!
|
|
Reporter | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•