901992 - B2G MMS: Retry Mechanism for Downloading MMS is Buggy

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Gene Lian (I already quit Mozilla)]

+++ This bug was initially created as a clone of Bug #840066 +++

Sometimes, the downloading circle is just spinning forever when retrieving MMS either by automatic or manual. After looking into the retry mechanism, I found out there are some bugs stopping the retry mechanism working well. Thanks Julien for discovering this! Let's fix it!

Hi Joe, we need to mark this as LEO+ because it blocks bug 840066 which is an important feature.

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

We have two bugs:

1. The binding for the second retry is wrong. I rewrite the logic just like the sending retry.

2. s/id/savableMessage.id/ to make it update the delivery status correctly.

Comment 2

[Preeti Raghunath(:Preeti)]

Please clarify the following:
1) What is the reproducible rate?
2) How easy is it to recover the message post this failure?

Comment 3

[Gene Lian (I already quit Mozilla)]

(In reply to Preeti Raghunath(:Preeti) from comment #2)
> Please clarify the following:
> 1) What is the reproducible rate?

This issue only happens when the platform fails to download the MMS, which could depend on the MMSC and network status. However, we can still reproduce the bug in an alternative way, which can has an 100% reproducing rate:

1. Settings -> Message Settings -> Auto retrieve -> Off -> OK.
2. Send an MMS to self and get an message for manual download.
3. Turn on the airplane mode in the settings.
4. Tap on the download button.
5. The downloading circle will keep spinning forever even after the 4 times retries (totally 2560 seconds later [1]). The expected behaviour is the spinning circle should become exclamation mark eventually.

[1] The platform has an automatic retry mechanism internally, which will try at most 4 times until the MMS is successfully downloaded. The time interval between each retry is 60, 300, 600, 1800 seconds respectively.

> 2) How easy is it to recover the message post this failure?

I don't understand this question.

Comment 4

[Julien Wajsberg [:julienw]]

(In reply to Gene Lian [:gene] from comment #3)
> (In reply to Preeti Raghunath(:Preeti) from comment #2)

> > 2) How easy is it to recover the message post this failure?
> 
> I don't understand this question.

After some time (about 1 day, maybe it was because I rebooted), I actually get the exclamation mark and then I can retry downloading the message, which eventually works.

Comment 5

[Gene Lian (I already quit Mozilla)]

Correct. You can get an exclamation mark again by rebooting. We fix this bug by correctly updating the delivery status at run-time if the MMS fails to download after all the retries.

Comment 6

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13d9724f03b1

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/13d9724f03b1

Comment 8

[Wayne Chang [:wchang]]

Triage - not a blocker by partner. Leaving moz triage to decide.

Comment 9

[Julien Wajsberg [:julienw]]

This is a real bug that happens quite often in real life (from a dogfood user).

Gene> could it be possible to write a testcase for this bug ?

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

It does work to retry at some point and without a partner champion we won't block v1.1 on this at this stage.  Bumping to koi? so this might get a higher priority in v1.2.

Comment 11

[Gene Lian (I already quit Mozilla)]

Hoping to uplift this to V1.1 because of Bug 917167. Renominating.

Comment 12

[Andrew Overholt [:overholt]]

Broken (or unreliable) new 1.1 feature (MMS) = blocker.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/60d177e0be64

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/60d177e0be64

Comment 15

[Gene Lian (I already quit Mozilla)]

Thanks Ryan for the manual merge which looks good to me.