902036 - [B2G][Settings][Media Storage]Spelling error on Default Media Location Information Screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Montoya Clemmons (MClemmons)]

Attachment: Screenshot of issue

Description:
Word "effect" should be replaced with "affect" as term is used as a verb. Dictionary.com states "affect" is primarily used as verb.

Preconditions: Beneath Advanced and beneath Default Media Location in [Settings] [Media Storage] Internal is default

Repro Steps:
1) Update Leo to Build ID: 20130806071254
2) Tap Settings App
3) Tap Media Storage
4) Beneath Advanced and beneath Default Media Location, tap Internal 

Actual:
Text appears that starts with "Changing the default media storage volume will effect ...

Expected:
Text appears that starts with "Changing the default media storage volume will affect ...

Environmental Variables
Build ID: 20130806071254
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a2a9b89ef5ee
Gaia: 4c1a20570e20f64782ba170c14604395c48f7381
Platform Version: 18.1
Firmware Version: D300f08o

Notes:
Repro frequency: (100%)
See attached: screenshot

Comment 1

[[e-mail]]

Attachment: pull_request.html

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 816440 [details]
pull_request.html

Please help check if changing ID is needed in this case, thanks!

Comment 3

[Francesco Lodolo [:flod]]

Typos or grammar errors don't require a new ID. In this case affect/effect doesn't really change the meaning of the sentence, so I would say no (leaving pike's flag to check if he agrees).

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 816440 [details]
pull_request.html

what flod said, f=me without ID change.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 816440 [details]
pull_request.html

r=me.

Comment 6

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/efa7b94e29a8e9612e6ef94d80d52b8051a2aeb1

thanks!

Comment 7

[[e-mail]]

Comment on attachment 816440 [details]
pull_request.html

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment] let l10n team can fix spell error together
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): low risk
[String changes made]:

Comment 8

[Preeti Raghunath(:Preeti)]

Please answer user impact if patch is declined.

Comment 9

[[e-mail]]

The impact is low, not essential one

Comment 10

[Preeti Raghunath(:Preeti)]

Comment on attachment 816440 [details]
pull_request.html

Minus, because the impact seems to be low and the release is at a cross road where only blockers will be taken.