902041 - Don't use the remote-browser.xml binding for remote thumbnail generation

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This binding was only designed to be used for electrolysis browsing. It uses CPOWs and stuff that should be unavailable except when browser.tabs.remote is set.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: restrict-e10s-xbl

Comment 2

[:Gavin Sharp [email: [e-mail]]]

You could avoid adding the class and just use "browserStack > browser" as the selector for CSS. I think I prefer that.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: restrict-e10s-xbl v2

Yeah, that's much better.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 786495 [details] [diff] [review]
restrict-e10s-xbl v2

Hmm, thinking about this a bit further, given the location of this style rule, it would not have been applied to the background thumbnailing service's browsers, because those live in the hidden window (where browser.css is not loaded). So I don't think this is related to bug 800347, and it shouldn't really change much in practice. But I guess it doesn't hurt to do it anyways.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d7a54bd0ccb

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7d7a54bd0ccb