Closed Bug 902041 Opened 6 years ago Closed 6 years ago

Don't use the remote-browser.xml binding for remote thumbnail generation

Categories

(Firefox :: General, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 26

People

(Reporter: billm, Assigned: billm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

This binding was only designed to be used for electrolysis browsing. It uses CPOWs and stuff that should be unavailable except when browser.tabs.remote is set.
Attached patch restrict-e10s-xbl (obsolete) — Splinter Review
Attachment #786489 - Flags: review?(gavin.sharp)
You could avoid adding the class and just use "browserStack > browser" as the selector for CSS. I think I prefer that.
Yeah, that's much better.
Attachment #786489 - Attachment is obsolete: true
Attachment #786489 - Flags: review?(gavin.sharp)
Attachment #786495 - Flags: review?(gavin.sharp)
Comment on attachment 786495 [details] [diff] [review]
restrict-e10s-xbl v2

Hmm, thinking about this a bit further, given the location of this style rule, it would not have been applied to the background thumbnailing service's browsers, because those live in the hidden window (where browser.css is not loaded). So I don't think this is related to bug 800347, and it shouldn't really change much in practice. But I guess it doesn't hurt to do it anyways.
Attachment #786495 - Flags: review?(gavin.sharp) → review+
Blocks: fxe10s
https://hg.mozilla.org/mozilla-central/rev/7d7a54bd0ccb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.