Users are now used to the # symbol when adding tags, however, these don't appear in searches. Eg https://brett.makes.org/thimble/hash-tag-test I tagged this as #oprah, but a search for #oprah or oprah doesn't return this make https://webmaker.org/en-US/search?type=all&q=%23oprah
This is most definitely being caused by https://github.com/mozilla/webmaker.org/blob/136a8d6b38a0b6844f469e4c5548f281e11ef19f/routes/search.js#L51 I'm looping in Dale to get his perspective on why we strip the hashtag out. The MakeAPI stores tags as they are, so "#oprah" will only match "#oprah" and not "oprah". We need standardize what a tag is across Webmaker. Are tags denoted by prefacing them with a "#" client side, and we store them without a hash in the makeAPI? this would mean all points of entry for a tag will need to strip the hash (a process not visible to the user) and add the hash back on when it's being displayed.
yeah but search for #oprah. you get nothing. So at the very least, that should work.
(In reply to Brett Gaylor [:brett] from comment #2) > yeah but search for #oprah. you get nothing. > > So at the very least, that should work. So at the very least, we should not strip hash tags?
correct - unless i'm not thinking through the implications. I know that we have set up search so you can use hashtags, ie webmaker.org/#oprah, and it will re-route. What is best way to not fail when a users add hashtag themselves?
When a user searches for a tag (via the url search or on the /search page), I'm just sending the search keyword without the # symbol to the MakeAPI. To the user, the tag is #oprah but to the MakeAPI, it's just Oprah. This doesn't need to change from the user's perspective. If I recall correctly, the apps also save the tags in the same way (stripping out the hashtag, making tagging transparent to the user). I could be wrong, and then a quick fix would resolve this?
Created attachment 787078 [details] [review] https://github.com/mozilla/webmaker.org/pull/321 This patch stops hash tag removal from search terms.
Attachment #787078 - Flags: review?(dale)
This branch is a simple solution that just opens the event info window after it is created. https://github.com/cadecairos/webmaker-events/compare/bug901975-2
(In reply to Chris DeCairos (:cade) from comment #7) > This branch is a simple solution that just opens the event info window after > it is created. > > https://github.com/cadecairos/webmaker-events/compare/bug901975-2 wrong bug -.-
Attachment #787078 - Flags: review?(dale) → review?(schranz.m)
Attachment #787078 - Flags: review?(schranz.m) → review+
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/ad8ab907c6378e8fca581148a3d4b9d3165bce60 Fix Bug 902043 - Don't strip the hashtag from tag search terms
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.