902070 - [email/activesync] Change jswbxml to run its unit tests under mocha

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

jswbxml needs to be able to produce Blobs for bug 871897.  To confidently make this change I wanted to be able to run the tests more easily and do so under our 'mocha by default' testing regime for the productivity apps.

I've done this; creating the blob so I can make the commit/pull request/etc.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/jswbxml/pull/5

Pointer to Github pull-request

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 786415 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/jswbxml/pull/5

Jim, not sure about your current load level, but I have this and the aforementioned Blob fix coming up, so if you can't get to these fairly soon, please let me know and I'll see about finding who on the productivity team would like to learn more about the wild world of activesync! :)

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Uh, and the steps to run the tests are "npm install" then "npm test".  I can put that in the README.md...

Comment 4

[James Lal [:lightsofapollo]]

:cough: :cough: use a Makefile so people can just do |make test| if your worried about non node people.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

non-node people will still need node, but I added a Makefile so that "make", "make test", "make tests", or "make check" will do "npm install" followed by "npm test".

I also added some minimal words to the README.md

Note that the w3c-blob dep gets removed in the follow-on patch because it turns out its Blob implementation was too limited for the needs of my unit test.

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 786415 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/jswbxml/pull/5

r=squib on the pull request

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

landed in jswbxml/master and then cascaded through all repos:

https://github.com/mozilla-b2g/jswbxml/pull/5
https://github.com/mozilla-b2g/jswbxml/commit/3f6d552bb6d57a9382671e9e72dc352451de5f8f

https://github.com/mozilla-b2g/jsas/pull/13
https://github.com/mozilla-b2g/jsas/commit/e2c03640720f1c030af5de1a2e43db050d1ea1ee

https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/236
https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/a1728b69a35da0bbaadd804b8ea0b3d068431f9f

https://github.com/mozilla-b2g/gaia/pull/11632
https://github.com/mozilla-b2g/gaia/commit/145c6675b969515663ef9926c8df2055ca17b50f


Note that the GELAM commit actually references the jsas fix commit rather than the merge commit due to a glitch on my part.  I didn't push a second GELAM patch since the tree state and resulting gaia state is identical and Jim has a jsas fix that should land soon and correct my foolishness.