Closed
Bug 902081
Opened 11 years ago
Closed 11 years ago
xpcshell test xpcom/tests/unit/test_systemInfo.js fails on Android x86 emulator and Android 4.0/Panda
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
(Whiteboard: [reit-x86])
Attachments
(1 file)
1000 bytes,
patch
|
cmtalbert
:
review+
|
Details | Diff | Splinter Review |
On Android x86 emulators, I can run most xpcshell tests successfully, but a few fail -- this is one of them. 23:06:39 WARNING - TEST-UNEXPECTED-PASS | /home/cltbld/tests/scripts/scripts/build/tests/xpcshell/tests/xpcom/tests/unit/test_systemInfo.js | test failed (with xpcshell return code: 0), see following log: 654 23:06:39 INFO - >>>>>>> 655 23:06:39 INFO - xpcw: cd /mnt/sdcard/tests/xpcshell/xpcom/tests/unit 656 23:06:39 INFO - xpcw: xpcshell -r /mnt/sdcard/tests/xpcshell/c/httpd.manifest --greomni /data/local/xpcb/fennec-25.0a1.multi.android-i386.apk -m -n -s -e const _HTTPD_JS_PATH = "/mnt/sdcard/tests/xpcshell/c/httpd.js"; -e const _HEAD_JS_PATH = "/mnt/sdcard/tests/xpcshell/head.js"; -e const _TESTING_MODULES_DIR = "/mnt/sdcard/tests/xpcshell/m"; -f /mnt/sdcard/tests/xpcshell/head.js -e const _SERVER_ADDR = "localhost" -e const _HEAD_FILES = ["/mnt/sdcard/tests/xpcshell/xpcom/tests/unit/head_xpcom.js"]; -e const _TAIL_FILES = []; -e const _TEST_FILE = ["test_systemInfo.js"]; -e _execute_test(); quit(0); 657 23:06:39 INFO - TEST-INFO | (xpcshell/head.js) | test MAIN run_test pending (1) 658 23:06:39 INFO - Testing property: name 659 23:06:39 INFO - TEST-PASS | test_systemInfo.js | [run_test/< : 14] true == true 660 23:06:39 INFO - Testing property: host 661 23:06:39 INFO - TEST-PASS | test_systemInfo.js | [run_test/< : 14] true == true 662 23:06:39 INFO - Testing property: arch 663 23:06:39 INFO - TEST-PASS | test_systemInfo.js | [run_test/< : 14] true == true 664 23:06:39 INFO - Testing property: version 665 23:06:39 INFO - TEST-PASS | test_systemInfo.js | [run_test/< : 14] true == true 666 23:06:39 INFO - Testing property: pagesize 667 23:06:39 INFO - TEST-PASS | test_systemInfo.js | [run_test/< : 14] true == true 668 23:06:39 INFO - Testing property: pageshift 669 23:06:39 INFO - TEST-PASS | test_systemInfo.js | [run_test/< : 14] true == true 670 23:06:39 INFO - Testing property: memmapalign 671 23:06:39 INFO - TEST-PASS | test_systemInfo.js | [run_test/< : 14] true == true 672 23:06:39 INFO - Testing property: cpucount 673 23:06:39 INFO - TEST-PASS | test_systemInfo.js | [run_test/< : 14] true == true 674 23:06:39 INFO - Testing property: memsize 675 23:06:39 INFO - TEST-PASS | test_systemInfo.js | [run_test/< : 14] true == true 676 23:06:39 INFO - TEST-INFO | (xpcshell/head.js) | test MAIN run_test finished (1) 677 23:06:39 INFO - TEST-INFO | (xpcshell/head.js) | exiting test 678 23:06:39 INFO - TEST-PASS | (xpcshell/head.js) | 9 (+ 0) check(s) passed 679 23:06:39 INFO - TEST-INFO | (xpcshell/head.js) | 0 check(s) todo 680 23:06:39 INFO - ^@ 681 23:06:39 INFO - <<<<<<<
Assignee | ||
Comment 1•11 years ago
|
||
So the issue here is really why does this test fail on Android 2.2? See bug 676998 and especially https://bugzilla.mozilla.org/show_bug.cgi?id=661351#c0. I think we either need to distinguish android 2.2 from android 2.3+ in the test manifest, or simply skip this test on all androids.
Assignee | ||
Comment 2•11 years ago
|
||
As expected, this fails (UNEXPECTED-PASS) on Panda/Android 4.0 -- https://tbpl.mozilla.org/php/getParsedLog.php?id=26549350&tree=Try&full=1
Summary: xpcshell test xpcom/tests/unit/test_systemInfo.js fails on Android x86 emulator → xpcshell test xpcom/tests/unit/test_systemInfo.js fails on Android x86 emulator and Android 4.0/Panda
Updated•11 years ago
|
Whiteboard: [reit-x86]
Assignee | ||
Comment 3•11 years ago
|
||
test_systemInfo.js fails on Android 2.2 and is currently marked as fail-if = os == "android". On all newer Androids, the test passes (see https://bugzilla.mozilla.org/show_bug.cgi?id=661351#c0), causing an unexpected pass on Android 4.0/panda and on Android 4.2/x86. xpcshell manifests do not distinguish between different Android versions. We can get a clean run by skipping the test on all Androids. https://tbpl.mozilla.org/?tree=Try&rev=ebcb7c662822&showall=1
Attachment #790798 -
Flags: review?(ctalbert)
Comment on attachment 790798 [details] [diff] [review] skip test_systemInfo.js on android Review of attachment 790798 [details] [diff] [review]: ----------------------------------------------------------------- This is fine for a short term fix now, but I imagine that we're going to hit more of these as we get closer to EOL with the tegras. So let's open a follow-up bug for adding support to the xpcshell manifest to differentiate between android OS versions.
Attachment #790798 -
Flags: review?(ctalbert) → review+
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Clint Talbert ( :ctalbert ) from comment #4) > So let's open a follow-up bug Bug 906081 filed.
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3790c84fc9db
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3790c84fc9db
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•