Closed Bug 902101 Opened 11 years ago Closed 6 years ago

Add option to disable search and form history (formfill, autofill) on Android

Categories

(Firefox for Android Graveyard :: Logins, Passwords and Form Fill, defect)

23 Branch
All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INACTIVE

People

(Reporter: sbporter, Unassigned, NeedInfo)

References

Details

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130729175331




Expected results:

For convenience and feature parity, I'd like to see the "Remember search and form history" option implemented on Android.

Chrome for Android has an "Autofill forms" yes/no toggle in its settings menu, whereas Firefox requires digging into about:config (more of a pain on mobile than on desktop) and changing "browser.formfill.enable" to false.
Severity: normal → enhancement
OS: Windows 8 → Android
Hardware: x86_64 → ARM
Hardware: ARM → All
Seconded. I'd like to add that, due to this limitation, form and search history is included in sync, and is thus pushed to desktop Firefox clients even if they have disabled "Remember form and search history" there, which is a waste of bandwidth and may have some security implications if users are unaware of it (and I certainly didn't expect this behaviour).
sbporter,

In light of my finding above, would you be willing to regrade this bug's importance back to "normal"?  (There might even be a case for "major" in light of the security issue, but I tend to think that's for the wranglers to decide.)

Alternatively I can start a new bug that depends on this one: your call.
As suggested, I switched it back to normal.
Severity: enhancement → normal
Even with the about:config entry switched to false, I still saw form history with Google searches on my phone yesterday. It seems the setting is broken.
Adding UX for some thoughts on whether we should make a visible Setting for this. Could be considered Privacy related.
Flags: needinfo?(ywang)
Flags: needinfo?(randersen)
Flags: needinfo?(alam)
I think an option in side "Settings > Privacy" seems to make sense for this. 

Do we have anything in place to handle any sort of "editting" capabilities (similar to updating a changed password)? Or is this a simple, all powerful checkbox that would enable or disable the feature altogether?
Flags: needinfo?(alam)
(In reply to Anthony Lam (:antlam) from comment #6)
> I think an option in side "Settings > Privacy" seems to make sense for this. 
> 
> Do we have anything in place to handle any sort of "editting" capabilities
> (similar to updating a changed password)? Or is this a simple, all powerful
> checkbox that would enable or disable the feature altogether?

Updating a changed password that has been saved should trigger a doorhanger, like Desktop, prompting you to save the changed password. Passwords are controlled using a different preference than Formfill. Also note that Desktop stores the previously types searches in the main toolbar Search Box, but Fennec does not have a corresponding feature.

This bug is basically about web content Formfill, controlled using the Gecko pref:
browser.formfill.enable

Passwords have a different set of preferences and behaviors:
signon.rememberSignons = prompt to remember passwords?
signon.autofillForms = if a saved password was found, should we auto-fill it in the web content?
signon.storeWhenAutocompleteOff = should we ignore the web content "autocomplete=no" attribute?
(I think those are right)
Agreed, an option in Settings/Privacy would be the right place. The expected behavior is to not have the forms/fields filled in/saved if you uncheck the box, but it sounds like in order to wipe what's already cached from sync a restart is required. A simple alert message stating this should suffice, with an option to continue or cancel. Not optimal to restart, but it seems to be the only option if you had the option set to yes and then decided to not save, rather than on first use.

And yes Mark, an update to an already saved password would give you a doorhanger, with a text CTA to confirm that you're updating the password. Do we support this capability from mobile?

And if we don't currently support saved searches across devices, I suppose now might be the time to explore it.
Flags: needinfo?(randersen)
(In reply to Robin Andersen [:tecgirl] from comment #8)

> And yes Mark, an update to an already saved password would give you a
> doorhanger, with a text CTA to confirm that you're updating the password. Do
> we support this capability from mobile?

Yep. Already supported.

> And if we don't currently support saved searches across devices, I suppose
> now might be the time to explore it.

Yeah. New service. Although, now that you mention it, we do support saving searches right now, locally on the device. We only display search history in the Search Activity, but searches are saved in Fennec and the Search Activity.

It's used differently enough that I think we'd want a separate setting to control saving search history and not piggyback it on to the Formfill.
I don't understand how is this still unconfirmed. Clearing history and form doesn't clear search history still as of 36.0.4, a pretty major privacy concern.
In Firefox 38.0.5 for Android, I see absolutely no way to disable browsing history.
Is there at least an option in about:config?
Hi,

Does this issue still reproduce?

Thanks!
Flags: needinfo?(sbporter)
I just did a quick test on Google.com, and yes, it still exists.

On the plus side, addons.mozilla.org seems to no longer be suggesting search history from other sites.
Component: General → Logins, Passwords and Form Fill
Flags: needinfo?(sbporter)
Closing per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Contact :susheel if you think this bug should be re-opened
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.