902117 - Creation dates of makes are off

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[Brett Gaylor [:brett]]

So this is a known bug, but we need to fix.

Creation dates are off wildly, so that almost all makes say they were created yesterday etc.  This is very confusing for users and we should invest in the solution.

Comment 1

[Chris DeCairos (:cade)]

Completing bug 888290 should fix this issue. Shall I make that my priority for this week?

Comment 2

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/132

Instead of waiting for the elastical/sequelize change, I'm just going to remove the pre save hook and handle `updatedAt` updating in the update route (which apparently was already being done >.>)

Comment 3

[Chris DeCairos (:cade)]

Brett - did you mean the "updatedAt" field instead of "createdAt"? I've never seen or heard of createdAt being set incorrectly.

Comment 4

[David Humphrey (:humph)]

Comment on attachment 787663 [details] [review]
https://github.com/mozilla/MakeAPI/pull/132

Looks good to me.

Flagging Brett for feedback based on question cade asked above.

Comment 5

[Brett Gaylor [:brett]]

Right, Chris.  You're correct its the "updated at" messaging in MyMakes that is confusing.  i updated a make and checked in the makeEditor, the createdAt day was still correct. Land away.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/64660dcc4ac4aa8af258f9553afda7b59867631b
Bug 902117 - Remove pre save hook that updates updatedAt field

Comment 8

[Brett Gaylor [:brett]]

feedback!