Closed Bug 902125 Opened 12 years ago Closed 10 years ago

Add a version config/flag for Python Marionette (and JavaScript version too if we don't have one)

Categories

(Remote Protocol :: Marionette, defect)

x86
macOS
defect
Not set
normal

Tracking

(firefox42 fixed)

RESOLVED FIXED
mozilla42
Tracking Status
firefox42 --- fixed

People

(Reporter: pdehaan, Assigned: parkouss)

References

Details

(Keywords: pi-marionette-runner)

Attachments

(1 file)

I tried running marionette --version from the command line, but it didn't care for that one bit. I asked in #ateam and we discussed possibly adding a marionette.__version__ flag.
For Python packages, you can get a list of version numbers using 'pip freeze'. Is this sufficient? Also, the Python package version is not necessarily the version of the Marionette implementation is gecko, which is currently unversioned. We are thinking of returning the Gecko version for that. Which version do you need?
would adding a marionette.__version__ item be enough for this bug?
Flags: needinfo?(pdehaan)
Adding `__version__` would probably work. I currently have marionette installed but not sure what version. I'm not a Python guy, but `pip freeze` seems to give me a version number: ``` $ pip freeze | grep "marionette" Warning: cannot find svn location for mercurial==2.6.2-20130606 marionette-client==0.5.37 ```
Flags: needinfo?(pdehaan)
Attached patch 902125.patchSplinter Review
This patch add a marionette.__version__ flag and a --version command line. Note that the version is now in the marionette/__init__.py file. Maybe we want to show version dependencies for marionette-drivers for example, this could be addresses in follow up bugs (because in this case we would need __version__ from the marionette-drivers package also). Last thing, this patch will probably conflict with one of my other patches, but it will be easy to fix.
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Attachment #8632638 - Flags: review?(dburns)
Attachment #8632638 - Flags: review?(dburns) → review+
Yes, ideally --version would report the versions of marionette-driver and marionette-transport as well; can you file a follow-up for this?
Blocks: 1183157
Sure! I just created Bug 1183157 for that. :)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Depends on: 1184052
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: