Closed
Bug 902149
Opened 12 years ago
Closed 12 years ago
Render make embed shell dynamically
Categories
(Webmaker Graveyard :: Make Valet, defect)
Webmaker Graveyard
Make Valet
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jon, Assigned: jon)
References
Details
Attachments
(1 file)
Instead of having each tool render a static embed shell and publish on S3, the make valet should render the embed shell dynamically.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #787164 -
Flags: review?(kate)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 787164 [details] [review]
https://github.com/mozilla/make-valet/pull/9
One thing to note in this patch, the makedetails.less file is basically just a copy from thimble's repo.
Attachment #787164 -
Flags: review?(kate) → review?(gavin)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #787164 -
Flags: review?(gavin) → review?(kate)
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 787164 [details] [review]
https://github.com/mozilla/make-valet/pull/9
This looks good now, less+js needs some fixing in another patch
Attachment #787164 -
Flags: review?(kate) → review+
|
||
Comment 4•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/make-valet
https://github.com/mozilla/make-valet/commit/9b0c5d7277034ac9856b68f772083852dc5df1ae
Fix bug 902149 - Render embed shell dynamically
|
|
||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•