Closed
Bug 902151
Opened 11 years ago
Closed 11 years ago
MediaRecorder does not need to tell the cycle collector about mReadThread
Categories
(Core :: Audio/Video: Recording, defect)
Core
Audio/Video: Recording
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: khuey, Assigned: rlin)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
|
1.21 KB,
patch
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/rev/00c70533490e#l3.32
nsIThread implementations are never cycle collected (since have threadsafe refcounting, and the cycle collector cannot deal with multiple threads) so the cycle collector does not need to be told about mReadThread.
I'd be happy to review a patch ;-)
Assignee: nobody → rlin
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #786752 -
Flags: review?(khuey)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 786752 [details] [diff] [review]
patch v1
Review of attachment 786752 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
Attachment #786752 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
check-in patch, carry reviewer.
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: checkin-needed
|
||
Updated•11 years ago
|
Attachment #786752 -
Attachment is obsolete: true
|
|
||
Comment 4•11 years ago
|
||
Whiteboard: checkin-needed
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•11 years ago
|
Component: Video/Audio → Video/Audio: Recording
You need to log in
before you can comment on or make changes to this bug.
Description
•