Closed Bug 902151 Opened 9 years ago Closed 9 years ago

MediaRecorder does not need to tell the cycle collector about mReadThread

Categories

(Core :: Audio/Video: Recording, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: khuey, Assigned: rlin)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

http://hg.mozilla.org/mozilla-central/rev/00c70533490e#l3.32

nsIThread implementations are never cycle collected (since have threadsafe refcounting, and the cycle collector cannot deal with multiple threads) so the cycle collector does not need to be told about mReadThread.

I'd be happy to review a patch ;-)
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #786752 - Flags: review?(khuey)
Comment on attachment 786752 [details] [diff] [review]
patch v1

Review of attachment 786752 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #786752 - Flags: review?(khuey) → review+
Attached patch check-in patchSplinter Review
check-in patch, carry reviewer.
Whiteboard: checkin-needed
Attachment #786752 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/d44618837423
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Whiteboard: [qa-]
Component: Video/Audio → Video/Audio: Recording
You need to log in before you can comment on or make changes to this bug.