MediaRecorder does not need to tell the cycle collector about mReadThread

RESOLVED FIXED in mozilla26

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: khuey, Assigned: rlin)

Tracking

unspecified
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

http://hg.mozilla.org/mozilla-central/rev/00c70533490e#l3.32

nsIThread implementations are never cycle collected (since have threadsafe refcounting, and the cycle collector cannot deal with multiple threads) so the cycle collector does not need to be told about mReadThread.

I'd be happy to review a patch ;-)
Created attachment 786752 [details] [diff] [review]
patch v1
Attachment #786752 - Flags: review?(khuey)
Comment on attachment 786752 [details] [diff] [review]
patch v1

Review of attachment 786752 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #786752 - Flags: review?(khuey) → review+
Created attachment 786758 [details] [diff] [review]
check-in patch

check-in patch, carry reviewer.
Whiteboard: checkin-needed
Attachment #786752 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/d44618837423
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26

Updated

5 years ago
Whiteboard: [qa-]
Component: Video/Audio → Video/Audio: Recording
You need to log in before you can comment on or make changes to this bug.