Develop Marionette unit test for OOP get_active_frame

RESOLVED FIXED in mozilla27

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rwood, Assigned: rwood)

Tracking

unspecified
mozilla27
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Develop a marionette (client) unit test to verify that get_active_frame works when using OOP frames.
(Assignee)

Comment 1

5 years ago
Created attachment 786640 [details] [diff] [review]
Marionette unit test for OOP getactiveframe
Attachment #786640 - Flags: review?(jgriffin)
Comment on attachment 786640 [details] [diff] [review]
Marionette unit test for OOP getactiveframe

Review of attachment 786640 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, can you add this to the manifest so we can run it on try?  Looks good other than the missing files.

::: testing/marionette/client/marionette/tests/unit/test_getactiveframe_oop.py
@@ +40,5 @@
> +            iframe1.style.height = "100px";
> +            iframe1.style.width = "100%%";
> +            iframe1.src = "%s";
> +            document.body.appendChild(iframe1);
> +            """ % self.marionette.absolute_url("test_oop_1.html"))

need to include test_oop_1.html in the patch (via 'hg add')

@@ +67,5 @@
> +            iframe2.style.height = "100px";
> +            iframe2.style.width = "100%%";
> +            iframe2.src = "%s";
> +            document.body.appendChild(iframe2);
> +            """ % self.marionette.absolute_url("test_oop_2.html"))

need to include test_oop_2.html in the patch

@@ +82,5 @@
> +
> +        # Switch to top-level then back to active frame 2, verify correct frame
> +        self.marionette.switch_to_frame()
> +        self.marionette.switch_to_frame(active_frame2)
> +        self.assertTrue("test_oop_2.html" in self.marionette.get_url())         

nit: extra whitespace at end of line
Attachment #786640 - Flags: review?(jgriffin) → review-
(Assignee)

Comment 3

5 years ago
Created attachment 787088 [details] [diff] [review]
Updated post-review patch
Attachment #786640 - Attachment is obsolete: true
Attachment #787088 - Flags: review?(jgriffin)
Comment on attachment 787088 [details] [diff] [review]
Updated post-review patch

Review of attachment 787088 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good; can you push this to tryserver?  -b do -p linux64,emulator -u marionette,marionette-webapi -t none
Attachment #787088 - Flags: review?(jgriffin) → review+
(Assignee)

Comment 5

5 years ago
Sorry for the delay, pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=060bb9f83ebc
(Assignee)

Comment 6

5 years ago
Didn't look at this for awhile, updated my repo and pushed to try again:
https://tbpl.mozilla.org/?tree=Try&rev=14a2c38e1631
(Assignee)

Comment 7

5 years ago
Created attachment 811176 [details] [diff] [review]
902179update.patch

Failed on try; made a small fix, carrying over the r+
Attachment #787088 - Attachment is obsolete: true
Attachment #811176 - Flags: review+
(Assignee)

Comment 8

5 years ago
Pushed the new patch to try:
https://tbpl.mozilla.org/?tree=Try&rev=eb9e7e0b98fa
https://hg.mozilla.org/mozilla-central/rev/3ed8d1a1b594
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.