902215 - [meta] Refactor HTMLInputElement using the strategy pattern

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Jonathan Watt [:jwatt]]

The code in HTMLInputElement.cpp is pretty horrible and a lot harder to work with than it should be. We should break up HTMLInputElement using the strategy pattern:

http://en.wikipedia.org/wiki/Strategy_pattern

Each input type should have its own "strategy" implementation in it its own separate file. For example, HTMLInputElementTypeFile would be for type="file", stored in HTMLInputElementTypeFile.{h|cpp}.

Comment 1

[Jessica Jong [:jessica] (inactive)]

I'm thinking using the strategy pattern together with the factory method. That is, |HTMLInputElement| stays as it is now, but it "has a" |InputType|, which is the base class for each of the input types, e.g. |NumberInputType|, |RadioInputType|, |DateInputType|, etc. Of course, we can add more level of inheritance if needed, for example, |InputType| <- |DateTimeInputType| <- |DateInputType|. And then we use the factory method to instantiate the correct |InputType|.

We can discuss more about it during the Hawaii All Hands. Any suggestions are welcome!

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

sounds all good. I guess one can start splitting functionality to "InputType" one by one, like first validation related stuff, then event handling, then something else... whichever order makes most sense.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Jessica basically fixed this in bug 1345767
https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/dom/html/input/InputType.h#34-37