902241 - [Lockscreen] Camera doesn't open when launched from the lockscreen

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Tapping the camera button from the lockscreen doesn't launch the camera, it simply dismisses the lockscreen (as the unlock button does) on latest master (70a9797) and v1-train (51f802f), however, if an unlock passcode is set, the secure camera works from the lockscreen.

Comment 1

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Apparently the camera is opened in the background only (I can see it in the cards view), but since it is not focused/switched to, the user has the impression that it isn't working.

Something might be going wrong with MozActivity as the issue seems to reproduce for multiple cases, the ones I tested listed below:
 * open camera from lockscreen
 * open gallery from camera app
 * open camera from gallery app

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Looks like Bug 896945

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Antonio - can you look at this bug and see if the regression is from your work in bug 896945.

Comment 4

[Antonio Manuel Amaya Calvo (:amac)]

Ok, making a build now. The gallery->camera->gallery was working after applying 896945 though, isn't it working now?

Comment 5

[Antonio Manuel Amaya Calvo (:amac)]

I can't reproduce the problem with today's M-C build (264e54846d4a) and Gaia Master (commit: 5613742eb005e0393ca060d0831060d9e17f6070). Both the unlock to camera and the Gallery->Camera->Gallery->Camera work correctly for me.

I'm going to compile a B2G18 + v1-train now. Did the build that failed include the 896945 patch on Gecko? Cause if it didn't then the failing behavior is expected (as expected as something not working can be :)).

Comment 6

[Antonio Manuel Amaya Calvo (:amac)]

Tried it also with B2G18(changeset:   119853:36bbc5943448) and v1-train (commit c60e3507d9df160e006d2e25967d26df2dc543cb Merge: 5628b2c 6d4a2de) and it's working correctly also (both launching the camera from the lock screen and doing the Gallery->Camera->Gallery dance.

I tried (both on M-C + Master and on B2G18 + v1-train) having the camera app not running before hand, and running beforehand both on foreground and background.

So this WFM, at least with the builds I mentioned. If you were running the latest gaia but with a Gecko that doesn't have 119817:150c3f4ad24b (B2G18) or 6f6a4ea042c0 (M-C) then it'll fail. 

Note that for some reason, bug 896945 isn't LeoVB, bug 892708 is LeoVB- and I don't know if it's in Leo builds or not, and I don't know if bug 888926 is on leo or not either. 

To be clear, if the patch bug 888926 is in leo builds, then BOTH (cause you can't apply clearly the second one without the first) the patches for bug 892708 and bug 896945 *have* to be on the build. Otherwise, you get the behavior described. If the patch for 888926 isn't on the build then nothing of this apply (but you'll get an incorrect behavior on Cost Control at least).

Comment 7

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

> So this WFM, at least with the builds I mentioned. If you were running the latest
> gaia but with a Gecko that doesn't have 119817:150c3f4ad24b (B2G18) or 6f6a4ea042c0
> (M-C) then it'll fail. 

Hi Antonio, thanks for taking a look at the cause of this. I flashed my unagi with the latest B2G18 + gaia and can't reproduce the bug anymore -- I was indeed only updating gaia and thus didn't get the gecko patch.

Might be important to consider that OTA updates might break apps like the camera (as highlighted in this bug) if the gecko relevant update is not applied as well.

Comment 8

[Antonio Manuel Amaya Calvo (:amac)]

Closing as WFM per comment 7 then.