Closed Bug 902305 Opened 9 years ago Closed 9 years ago

Change alarm repeat representation from a bitset to an object

Categories

(Firefox OS Graveyard :: Gaia::Clock, enhancement)

All
Gonk (Firefox OS)
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: oconnore, Assigned: oconnore)

References

Details

Attachments

(1 file)

The alarm API currently uses a string of bits (like "0110111") instead of an object that is self descriptive {monday:true, wednesday: true}.
Attached file github pull request
Attachment #786711 - Flags: review?(iliu)
Blocks: 898666
Comment on attachment 786711 [details] [review]
github pull request

Hi Eric,

I have addressed the a small nit on Github. Beside it, the pr is okay for me. And please add the bug number prefix the pr(I have added). It will help devs to find out regarding bug via comment log. Thanks for your effort.
Attachment #786711 - Flags: review?(iliu) → review-
Comment on attachment 786711 [details] [review]
github pull request

Hey Ian,

I updated the pull request with review fixes, and the unit tests that Rick asked for.
Attachment #786711 - Flags: review- → review?(iliu)
Comment on attachment 786711 [details] [review]
github pull request

It works for me. The repeat alarm works fine. Thanks.
Attachment #786711 - Flags: review?(iliu) → review+
Since the pr is merged, we can close the issue now.

gaia/master:  3d9a7457fe02b07961698a64a9039f2aeaa30104
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.