Closed Bug 902313 Opened 11 years ago Closed 4 years ago

Don't retry signing uploads if the response is 'File too large'

Categories

(Release Engineering :: General, defect, P5)

Product:
Release Engineering
Component:
General
Platform:
x86
All
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: nthomas, Unassigned)

Details

No point uploading large files 20 times when they're guaranteed to fail each time. We send a 400 response in this case, but send 400's for other errors too.
Sounds like the signing client shouldn't retry for a general 400, unless it's actually modified the request. Without looking at the code I would guess that we can just turn off retries altogether except for 5xx and connection errors.
Product: mozilla.org → Release Engineering
Priority: -- → P5
Component: General Automation → General

I think this bug outlived its usefulness since we switched to Autograph.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.