Closed
Bug 902332
Opened 11 years ago
Closed 11 years ago
Convert JS_{FALSE,TRUE} to {false,true}
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
(Whiteboard: [js:t])
Attachments
(3 files)
277.94 KB,
patch
|
Details | Diff | Splinter Review | |
10.34 KB,
patch
|
Details | Diff | Splinter Review | |
277.94 KB,
patch
|
luke
:
review+
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
I have two patches for this. The first patch I generated with this script: #! /bin/sh for f in `hg manifest` ; do perl -pi -e 's/JS_TRUE/true/g' "$f" perl -pi -e 's/JS_FALSE/false/g' "$f" done I then made changes to the following files by hand: - jstypes.h: Changed the comment and added the _DEPRECATED suffixes. - perf/jsperf.cpp and vm/Interpreter.cpp: reindented trailing \ chars on the macros. - various: avoided JSBool/bool comparisons that caused warnings-as-errors bustage on Windows. I'll post three patches -- the scripted part, the manual part, and the combination of the two.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 3•11 years ago
|
||
As before, luke for the JS parts, and bz for the rest. Thanks!
Attachment #786775 -
Flags: review?(luke)
Attachment #786775 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 4•11 years ago
|
||
Try run: https://tbpl.mozilla.org/?tree=Try&rev=a13f00823a12
Updated•11 years ago
|
Attachment #786775 -
Flags: review?(luke) → review+
Comment 5•11 years ago
|
||
Comment on attachment 786775 [details] [diff] [review] Convert JS_{FALSE,TRUE} to {false,true} r=me
Attachment #786775 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ade325617a73
Assignee | ||
Comment 7•11 years ago
|
||
For future reference, were the split automated/manual patches useful, or did you just look at the combined patch?
Comment 8•11 years ago
|
||
I carefully read the manual bit, then mostly-skimmed the combined patch, then checked on particular files (Codegen.py, which wasn't even changed, turns out) where there might have been particular weirdness.
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ade325617a73
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•