Closed Bug 902332 Opened 6 years ago Closed 6 years ago

Convert JS_{FALSE,TRUE} to {false,true}

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: njn, Assigned: njn)

References

Details

(Whiteboard: [js:t])

Attachments

(3 files)

I have two patches for this.  The first patch I generated with this script:

    #! /bin/sh
    for f in `hg manifest` ; do
        perl -pi -e 's/JS_TRUE/true/g' "$f"
        perl -pi -e 's/JS_FALSE/false/g' "$f"
    done

I then made changes to the following files by hand:

- jstypes.h: Changed the comment and added the _DEPRECATED suffixes.

- perf/jsperf.cpp and vm/Interpreter.cpp: reindented trailing \ chars on the
  macros.

- various: avoided JSBool/bool comparisons that caused warnings-as-errors
  bustage on Windows.

I'll post three patches -- the scripted part, the manual part, and the combination of the two.
Attached patch (scripted part)Splinter Review
Attached patch (manual part)Splinter Review
As before, luke for the JS parts, and bz for the rest.  Thanks!
Attachment #786775 - Flags: review?(luke)
Attachment #786775 - Flags: review?(bzbarsky)
Attachment #786775 - Flags: review?(luke) → review+
Comment on attachment 786775 [details] [diff] [review]
Convert JS_{FALSE,TRUE} to {false,true}

r=me
Attachment #786775 - Flags: review?(bzbarsky) → review+
For future reference, were the split automated/manual patches useful, or did you just look at the combined patch?
I carefully read the manual bit, then mostly-skimmed the combined patch, then checked on particular files (Codegen.py, which wasn't even changed, turns out) where there might have been particular weirdness.
https://hg.mozilla.org/mozilla-central/rev/ade325617a73
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.