902341 - [zffos1.1][sms]Extracting number from sms text

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[zhangdapeng]

Attachment: 13072912002013-07-29-15-09-35.png

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 2.0.50727; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; TCO_20130807094737)

Steps to reproduce:

Extracting number from text message and  save to contact




Actual results:

the bracket is extracted too, and the number must be more than or equal to 7 numbers can be extracted


Expected results:

the bracket should not extracted ，and the smallest resolved length is 3, no upper limit（According to requirement ）

Comment 1

[Scoobidiver (away)]

leo+ requested per bug 899451.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Is this a regression from v1.0.1?  Also, does this happen across more devices than just zte?

Comment 3

[dkumar]

I was able to reproduce this issue on V1.0.1 on both Alcatel (Buri) and ZTE (Unagi) 

Environmental Variables
Build ID: 20130808041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1433d653b701
Gaia: 5cb67ea419b0a642ea11b6c8f93c3ee50318e90a
Platform Version: 18.1

>Single bracket is extracted and saved in the contacts eg: (4244454535.
>The numbers that can be extracted or stored is equal to or greater than 6 yet less than 20.

Comment 4

[Alex Keybl [:akeybl]]

Not a regression, so bumping to koi? for 1.2 or later consideration.

Comment 5

[Juan Perez-Bedmar [:juanpbf]]

(In reply to Alex Keybl [:akeybl] from comment #4)
> Not a regression, so bumping to koi? for 1.2 or later consideration.

It is not a regression because this feature was not even supported in V1.0.1 :)
Anyway, this is not a blocking issue for certification, so we agree to consider it for koi

Comment 6

[Preeti Raghunath(:Preeti)]

Juan

Please confirm why this is needed in 1.2 - its not a cert blocker. So why is needed in 1.2

Comment 7

[Juan Perez-Bedmar [:juanpbf]]

(In reply to Preeti Raghunath(:Preeti) from comment #6)
> Juan
> 
> Please confirm why this is needed in 1.2 - its not a cert blocker. So why is
> needed in 1.2

So far, no operator has consider this issue as blocker for V1.1, but they have strongly requested to enhance this behaviour on "future releases". I really think is much safer to be prepared on beforehand and fix it in V1.2, as it will probably be considered as a cert blocker by the time they test V1.2, in some months.

Please, take my comments into consideration.
Thanks!

Comment 8

[Preeti Raghunath(:Preeti)]

David,

Please check on the bug as it might be a cert blocker.

Comment 9

[Julien Wajsberg [:julienw]]

We will never support extracting a 3-digit number, this will lead to too many false positives. With the current state we already have a lot of false positives.

We're lowering the limit to 5 for a number without separators in bug 900413, and I don't think we should catch smaller numbers. For example, if we try to catch 4-digit numbers we'll catch years and some big street numbers in addresses. If we try to catch 3-digit numbers this will be even worse.

About the bracket problem, we're catching the brackets for cases like (1)23456789. We could try to check if this match a closing brackets, but remember that the more guards we add, the slower the algorithm will be, and remember we need to run that algorithm on all messages. Do you really think this problem is worth it ?
Another possibility is to remove separators when we use the number as parameter to the activity, but I think this is not a good idea, and should be done by the Contacts app if necessary.

Anyway IMO this is too late for koi+, this is not a blocker because it's not a regression.

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

triage: minus, not a blocker for v1.2

Comment 11

[David Scravaglieri [:scravag]]

clear ni?

Comment 12

[Julien Wajsberg [:julienw]]

Hey,

is it still happening on current builds ?

Comment 13

[Julien Wajsberg [:julienw]]

(please test a 1.4 build)

Comment 14

[Natalya Kot [:nkot]]

have tested on the latest master build (1.4)

current behavior:
- if no brackets are used, the smallest number to extract is 5 
- if the number is in brackets, the smallest number to extract is 6 
- the bracket is extracted too

Device: Buri v1.4 Master build
BuildID: 20140122040205
Gaia: 8d18b1e2fd06c84a879f99f6e8ca1f104eeacb13
Gecko: 8f4ecbf938cd
Version: 29.0a1
Firmware Version: v1.2-device.cfg

Comment 15

[kumar rishav (:rishav_)]

Hi Julienw
Does this bug still exist?
Thanks

Comment 16

[Julien Wajsberg [:julienw]]

I think it does. You can check easily by running the app in Firefox and sending a SMS with such a number.

I'm not sure how to fix this in an efficient way though.

Comment 17

[Julien Wajsberg [:julienw]]

This is really not important as the feature works fine. Let's close this.