902346 - mozTCPSocket should respect the proxy preferences

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Frederik Braun [:freddy]]

Currently, mozTCPSocket does not respect the preferences that enable proxy support in Gecko (network.proxy.*). HTTP and SOCKS proxys are able to proxy non-HTTP connections, so this might be doable with little to none extra implementation effort

Comment 1

[Pochy]

In what state is this bug?, I see at the moment this blocks many bugs and posibility to implement a feature to change the proxy prefs to GAIA in firefox OS(setting app I suppose). Now the only way is edit the file(prefs.js) in profile device or WebIDE > Device Preferences. But the way should be in Gaia, i think.

Comment 2

[Ping Chen [:rnons] (away)]

Attachment: Bug 902346 - Support socks proxy in TCPSocket. r=mixedpuppy

• Add a password field to MozProxyInfo
• Add a proxyInfo field to SocketOptions
• When constructing a TCPSocket, the MozProxyInfo is converted to nsIProxyInfo, then passed to CreateTransport

Comment 3

[Shane Caraveo (:mixedpuppy)]

The socket should work more like other uses of proxy, relying on the proxy service to fetch a proxyInfo. That should allow proxy.settings to work, or proxy.onRequest to receive the event and return the proxyInfo, which can include the password. If credentials are otherwise needed, it should ask for the credentials, which would also trigger webRequest.onAuthRequired. proxy.RequestDetails has a type (webRequest.ResourceType) where a "tcpSocket" type could be added, since this is not a "webSocket".

Given that approach, no API change (other than adding "tcpSocket" to the resource type) or even any webidl changes are necessary. TCPSocket would then also work with manually entered proxy configurations (via about:preferences).

https://searchfox.org/mozilla-central/rev/d537e47349944c0fbd0100bd52c30e493e748c2e/netwerk/protocol/http/nsHttpChannel.cpp#6402

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/373160bb04a5
Support proxy in TCPSocket. r=necko-reviewers

Comment 5

[Alexandru Michis [:malexandru]]

Backed out changeset 373160bb04a5 (Bug 902346) for causing assertion failures in nsCOMPtr.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/375bea508a03d900321fb2e3564dcc6f1fb831a8

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=373160bb04a5ba02d06c6c09468fe4fe4696eef8

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=329477629&repo=autoland&lineNumber=31164
https://treeherder.mozilla.org/logviewer?job_id=329478010&repo=autoland&lineNumber=2179

Comment 6

[Ping Chen [:rnons] (away)]

Thanks, I made a fix. Try run: https://treeherder.mozilla.org/jobs?repo=try&revision=3b840893c8de176e683148576cf6364e7a4fa6c0

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b51cf4ac52f8
Support socks proxy in TCPSocket. r=mixedpuppy,necko-reviewers

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b51cf4ac52f8