Closed
Bug 902399
Opened 11 years ago
Closed 11 years ago
In the Contacts duplicates screen allow to show a summary of the matching contacts info
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:koi+)
VERIFIED
FIXED
blocking-b2g | koi+ |
People
(Reporter: jmcf, Assigned: jmcf)
References
Details
(Whiteboard: [u=commsapps-user c=contacts p=0])
Attachments
(3 files)
it will also needed to mark what fields are matching according to the wireframes.
Assignee | ||
Updated•11 years ago
|
blocking-b2g: --- → koi?
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=0]
Assignee | ||
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=0]
Updated•11 years ago
|
blocking-b2g: koi? → koi+
Whiteboard: [u=commsapps-user c=contacts p=0]
Comment 1•11 years ago
|
||
Hi Jose: is this really targeted for Sprint 3? Thanks
Flags: needinfo?(jmcf)
Comment 2•11 years ago
|
||
Hi again Joe, Don't think this will be part of sprint 3.
Assignee | ||
Updated•11 years ago
|
Flags: needinfo?(jmcf)
Comment 5•11 years ago
|
||
Assignee | ||
Comment 6•11 years ago
|
||
I don't understand very well the visual. When the horizontal lines should appear and when it shouldn't appear
Flags: needinfo?(vpg)
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #803669 -
Flags: review?(salva)
Comment 8•11 years ago
|
||
Jose Manuel, The horizontal lines where a reinforcement for the highlighted info in the details overlay, but just use the blue highlighting the in conflict data, and let's not use the horizontal lines. it might be enough with the colour. Thanks! V (In reply to Jose M. Cantera from comment #6) > I don't understand very well the visual. > > When the horizontal lines should appear and when it shouldn't appear
Flags: needinfo?(vpg)
Comment 9•11 years ago
|
||
Comment on attachment 803669 [details]
12163.html
Please, see my comments on GitHub.
Attachment #803669 -
Flags: review?(salva) → review-
Comment 10•11 years ago
|
||
Differences between current implementation and visuals provided are: 1- Currently, photo is very small and aligned to the right edge. It should have a margin and be bigger. 2- Currently, name is appearing two times: in the title and in the details. According to the visual, let's remove the one in the details. 3- Font-size is very small. Anyway, except for issue 2, I wont block on that (we will open another bug for polish). So, José Manuel, can you do the fixes and ask for review again? Thank you very much.
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Salvador de la Puente González [:salva] from comment #10) > Created attachment 803749 [details] > Current matching details implementation > > Differences between current implementation and visuals provided are: > > 1- Currently, photo is very small and aligned to the right edge. It should > have a margin and be bigger. That's something for polishing > > 2- Currently, name is appearing two times: in the title and in the details. > According to the visual, let's remove the one in the details. Nope. The title indicates which is the Contact we are talking about and in the details you need to show it because you may need to highlight it if there is matching. So it is not redundant at all. > > 3- Font-size is very small. > That's for a follow-up bug for polishing > Anyway, except for issue 2, I wont block on that (we will open another bug > for polish). So, José Manuel, can you do the fixes and ask for review again? > > Thank you very much. done
Assignee | ||
Updated•11 years ago
|
Attachment #803669 -
Flags: review- → review?(salva)
Comment 12•11 years ago
|
||
> >
> > 2- Currently, name is appearing two times: in the title and in the details.
> > According to the visual, let's remove the one in the details.
>
> Nope. The title indicates which is the Contact we are talking about and in
> the details you need to show it because you may need to highlight it if
> there is matching. So it is not redundant at all.
>
> >
My only concern is here. May be we can highlight the name in the title. Which is obvious is the name is repeated. Maybe the meaning is different but I think UX should take a look on this. Asking.
Flags: needinfo?(aymanmaat)
Comment 13•11 years ago
|
||
Comment on attachment 803669 [details]
12163.html
Providing a couple of nits are solved, you have the r+
Thank you very much.
Attachment #803669 -
Flags: review?(salva) → review+
Updated•11 years ago
|
Flags: needinfo?(aymanmaat)
Comment 15•11 years ago
|
||
Master: c0ff597baabf4433b767421d9a513b95f40c406a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 16•11 years ago
|
||
(In reply to Salvador de la Puente González [:salva] from comment #12) > > > > > > > 2- Currently, name is appearing two times: in the title and in the details. > > > According to the visual, let's remove the one in the details. > > > > Nope. The title indicates which is the Contact we are talking about and in > > the details you need to show it because you may need to highlight it if > > there is matching. So it is not redundant at all. > > > > > > > My only concern is here. May be we can highlight the name in the title. > Which is obvious is the name is repeated. Maybe the meaning is different but > I think UX should take a look on this. Asking. intention is to highlight the name in the title if there is a name match, therefore no duplication is required
Comment 17•11 years ago
|
||
Backed out: https://github.com/mozilla-b2g/gaia/commit/53f4abc76fc40e546034d60d48af5ca15898b9fe
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 18•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/8ccb741b6adcfe9a78b842c17e5874242c0f8b86
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 19•10 years ago
|
||
Tested and working 1.3 Hamachi Gecko: 7db76c3 Gaia: facd91d
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•