Closed Bug 902416 Opened 8 years ago Closed 8 years ago

[Contacts][Export/Import] Style polish. Adding new icons and CSS tweaks

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:koi+)

RESOLVED FIXED
blocking-b2g koi+

People

(Reporter: borjasalguero, Assigned: borjasalguero)

References

Details

(Whiteboard: visual design, visual-tracking [u=commsapps-user c=contacts p=0.5])

Attachments

(3 files, 1 obsolete file)

We need to add new icons for export/import. This is a follow up for bug 901471 as we need UX input.
Assignee: nobody → fbsc
blocking-b2g: --- → koi?
Depends on: 901471
Eric, we would need your help here! We would need import/export/... icons.Thanks!!! :)
Flags: needinfo?(epang)
(In reply to Borja Salguero [:borjasalguero] from comment #1)
> Eric, we would need your help here! We would need import/export/...
> icons.Thanks!!! :)

Hi Borja, I'm going to redirect this to Peter since he's the owner of iconography :).
Flags: needinfo?(epang) → needinfo?(pla)
Whiteboard: visual design, visual-tracking
As well we need to check the height of the buttons in the import panel. Currently is 6rems due to lists.css, but we should update this.
blocking-b2g: koi? → koi+
Whiteboard: visual design, visual-tracking → visual design, visual-tracking [u=commsapps-user c=contacts p=0]
Hi Eric/Borja,

What icons exactly are needed here? From the IxD spec as well as the visual sent by Vicky, it appears to be using the SIM card icon for import, and Bluetooth icon for export.  Are you looking for more generic icons to represent Import/Export?
Flags: needinfo?(pla)
Flags: needinfo?(fbsc)
Flags: needinfo?(epang)
(In reply to Peter La from comment #4)
> Hi Eric/Borja,
> 
> What icons exactly are needed here? From the IxD spec as well as the visual
> sent by Vicky, it appears to be using the SIM card icon for import, and
> Bluetooth icon for export.  Are you looking for more generic icons to
> represent Import/Export?

Borja should be able to provide you with more info. Thanks!
Flags: needinfo?(epang)
Hi! Today I'll check icons needed and I'll let you know. Thanks!
Flags: needinfo?(fbsc)
Hi folks,

Please Borja correct me if I'm wrong, I think the icon that we were missing was the bluetooth one, and Victoria already provided it.

If anything else is missing please let us know :)
We need icons for the actions of import/export (currently Im reusing other icons, SIM & SD icons, but probably we need new ones from UX). Peter, could you help us on this? Thanks!
Flags: needinfo?(pla)
Assignee: fbsc → jmcf
Restoring the assignment due to my PTO day is over :). Peter, is there any update here?
Whiteboard: visual design, visual-tracking [u=commsapps-user c=contacts p=0] → visual design, visual-tracking [u=commsapps-user c=contacts p=0.5]
perhaps epang can help
Flags: needinfo?(epang)
Attached image ExportImport.png
Adding attachment of the screen which need some icons! ;)
Hi Borja/Eric,

Attached are the icons for import contacts / export contacts + a screenshot showing what they look like in context.

Please let me know if you have any concerns or request for changes.

Thanks,
Peter
Flags: needinfo?(pla)
Flags: needinfo?(epang)
Comment on attachment 802165 [details]
Problem in other dialogs (send report)

Sorry for the SPAM. THis is for other bug! Im working currently in the patch for the issue of the icons :)
Attachment #802165 - Attachment is obsolete: true
Assignee: jmcf → fbsc
Attached file Pull request
Attachment #802242 - Flags: review?(jmcf)
Comment on attachment 802242 [details]
Pull request

happy to see this fixed, thanks!
Attachment #802242 - Flags: review?(jmcf) → review+
Thanks Peter for the icons! :)
You need to log in before you can comment on or make changes to this bug.