[Contacts][Export/Import] Style polish. Adding new icons and CSS tweaks

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: borjasalguero, Assigned: borjasalguero)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:koi+)

Details

(Whiteboard: visual design, visual-tracking [u=commsapps-user c=contacts p=0.5])

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We need to add new icons for export/import. This is a follow up for bug 901471 as we need UX input.
(Assignee)

Updated

5 years ago
Assignee: nobody → fbsc
blocking-b2g: --- → koi?
Depends on: 901471
(Assignee)

Comment 1

5 years ago
Eric, we would need your help here! We would need import/export/... icons.Thanks!!! :)
Flags: needinfo?(epang)
(In reply to Borja Salguero [:borjasalguero] from comment #1)
> Eric, we would need your help here! We would need import/export/...
> icons.Thanks!!! :)

Hi Borja, I'm going to redirect this to Peter since he's the owner of iconography :).
Flags: needinfo?(epang) → needinfo?(pla)

Updated

5 years ago
Whiteboard: visual design, visual-tracking
(Assignee)

Comment 3

5 years ago
As well we need to check the height of the buttons in the import panel. Currently is 6rems due to lists.css, but we should update this.
blocking-b2g: koi? → koi+
Whiteboard: visual design, visual-tracking → visual design, visual-tracking [u=commsapps-user c=contacts p=0]

Comment 4

5 years ago
Hi Eric/Borja,

What icons exactly are needed here? From the IxD spec as well as the visual sent by Vicky, it appears to be using the SIM card icon for import, and Bluetooth icon for export.  Are you looking for more generic icons to represent Import/Export?
Flags: needinfo?(pla)

Updated

5 years ago
Flags: needinfo?(fbsc)
Flags: needinfo?(epang)
(In reply to Peter La from comment #4)
> Hi Eric/Borja,
> 
> What icons exactly are needed here? From the IxD spec as well as the visual
> sent by Vicky, it appears to be using the SIM card icon for import, and
> Bluetooth icon for export.  Are you looking for more generic icons to
> represent Import/Export?

Borja should be able to provide you with more info. Thanks!
Flags: needinfo?(epang)
(Assignee)

Comment 6

5 years ago
Hi! Today I'll check icons needed and I'll let you know. Thanks!
Flags: needinfo?(fbsc)
Hi folks,

Please Borja correct me if I'm wrong, I think the icon that we were missing was the bluetooth one, and Victoria already provided it.

If anything else is missing please let us know :)
(Assignee)

Comment 8

5 years ago
We need icons for the actions of import/export (currently Im reusing other icons, SIM & SD icons, but probably we need new ones from UX). Peter, could you help us on this? Thanks!
Flags: needinfo?(pla)

Updated

5 years ago
Assignee: fbsc → jmcf
(Assignee)

Comment 9

5 years ago
Restoring the assignment due to my PTO day is over :). Peter, is there any update here?
(Assignee)

Updated

5 years ago
Whiteboard: visual design, visual-tracking [u=commsapps-user c=contacts p=0] → visual design, visual-tracking [u=commsapps-user c=contacts p=0.5]
perhaps epang can help
Flags: needinfo?(epang)
(Assignee)

Comment 11

5 years ago
Created attachment 801599 [details]
ExportImport.png

Adding attachment of the screen which need some icons! ;)

Comment 12

5 years ago
Created attachment 802024 [details]
Contacts_Import_Export_Icons.zip

Hi Borja/Eric,

Attached are the icons for import contacts / export contacts + a screenshot showing what they look like in context.

Please let me know if you have any concerns or request for changes.

Thanks,
Peter
Flags: needinfo?(pla)

Updated

5 years ago
Flags: needinfo?(epang)
(Assignee)

Comment 13

5 years ago
Created attachment 802165 [details]
Problem in other dialogs (send report)
(Assignee)

Comment 14

5 years ago
Comment on attachment 802165 [details]
Problem in other dialogs (send report)

Sorry for the SPAM. THis is for other bug! Im working currently in the patch for the issue of the icons :)
Attachment #802165 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Assignee: jmcf → fbsc
(Assignee)

Comment 15

5 years ago
Created attachment 802242 [details]
Pull request
Attachment #802242 - Flags: review?(jmcf)

Comment 16

5 years ago
Comment on attachment 802242 [details]
Pull request

happy to see this fixed, thanks!
Attachment #802242 - Flags: review?(jmcf) → review+
(Assignee)

Comment 18

5 years ago
Thanks Peter for the icons! :)
You need to log in before you can comment on or make changes to this bug.