Closed Bug 902530 Opened 11 years ago Closed 11 years ago

Intermittent browser_pluginnotification.js | uncaught exception - TypeError: can't access dead object at chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js:104 | Test timed out | Found a tab after previous test ...

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox24 fixed, firefox25 fixed, firefox26 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla26
Tracking Flags:
Tracking Status
firefox24 --- fixed
firefox25 --- fixed
firefox26 --- fixed

People

(Reporter: RyanVM, Assigned: gfritzsche)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Fix contentDocument usage from test wrapper function.
3.99 KB, patch
jaws
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=26240781&tree=Mozilla-Inbound

Windows 7 32-bit mozilla-inbound debug test mochitest-browser-chrome on 2013-08-06 17:15:10 PDT for push b5319d82251e
slave: t-w732-ix-081

17:23:36  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | uncaught exception - TypeError: can't access dead object at chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js:104
17:23:36     INFO -  Stack trace:
17:23:36     INFO -      JS frame :: chrome://mochikit/content/tests/SimpleTest/SimpleTest.js :: simpletestOnerror :: line 1136
17:23:36     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
17:23:36     INFO -  JavaScript error: chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js, line 104: can't access dead object
17:23:36     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | Console message: [JavaScript Error: "TypeError: can't access dead object" {file: "chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js" line: 104}]

yadda yadda yadda...

17:24:00     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | Longer timeout required, waiting longer...  Remaining timeouts: 1
17:24:00     INFO -  --DOMWINDOW == 23 (1A55C0E0) [serial = 1331] [outer = 00000000] [url = about:blank]
17:24:30  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | Test timed out
17:24:30     INFO -  args: ['C:\\slave\\test\\build\\tests\\bin\\screenshot.exe', 'c:\\users\\cltbld\\appdata\\local\\temp\\mozilla-test-fail_mjvym1']
17:24:30     INFO -  SCREENSHOT: <see log>
17:24:30     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | finished in 60084ms
17:24:30  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_pluginnotification.js | Found a tab after previous test timed out: http://127.0.0.1:8888/browser/browser/base/content/test/plugin_test.html
(In reply to Georg Fritzsche [:gfritzsche] from comment #1)
> Hm, that looks like doc is dead at [1] for the test18f wrapper [2].
> I wonder if i actually can take the doc in the outer scope for
> runAfterPluginBindingAttached() [3].
>  
> [1]
> http://hg.mozilla.org/mozilla-central/annotate/fd4cf30428b0/browser/base/
> content/test/browser_pluginnotification.js#l104
> [2]
> http://hg.mozilla.org/mozilla-central/annotate/fd4cf30428b0/browser/base/
> content/test/browser_pluginnotification.js#l433
> [3]
> http://hg.mozilla.org/mozilla-central/annotate/fd4cf30428b0/browser/base/
> content/test/browser_pluginnotification.js#l102

jaws, does that look wrong or prone to races to you?
Flags: needinfo?(jaws)
So you just want to directly reference gTestBrowser.contentDocument inside of the anonymous function at http://hg.mozilla.org/mozilla-central/annotate/fd4cf30428b0/browser/base/content/test/browser_pluginnotification.js#l103 ?
Flags: needinfo?(jaws)
Yes, but i'm not sure if this would fix it as i'm not sure why the way it's currently done would be problematic. doc being dead does seem like the only logical conclusion here though.
Assignee: nobody → georg.fritzsche
Blocks: 896965
This is a follow-up to bug 896965 where i accidentally left |doc| in the wrong scope. I was now educated that those are actually different |contentDocument|s, sorry about the above confusion.

This also removes one erroneous use of the helper function. The second removal of the helper function usage (test20a) is not strictly needed, but currently bug 904222 would trigger test failures if it were left as-is.

https://tbpl.mozilla.org/?tree=Try&rev=bd21a7c442dc
Attachment #789164 - Flags: review?(jaws)
Attachment #789164 - Flags: review?(jaws) → review+
Comment 20 failure is different, presume the patch has just morphed it?
Flags: needinfo?(georg.fritzsche)
https://hg.mozilla.org/mozilla-central/rev/cc2b1f42aa6a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
(In reply to Ed Morley [:edmorley UTC+1] from comment #21)
> Comment 20 failure is different, presume the patch has just morphed it?

It's rather a possible variation of bug 896965, not this bug - although i'm not sure how we could still hit it after the fixes there.
Flags: needinfo?(georg.fritzsche)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: