90254 - blank menu item under Privacy and Security

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[J Luh]

On Mozilla for Mac OS X, 2001071013, there is a blank menu item under Privacy
and Security.

Select Tasks -> Privacy and Security.

The last menu item, under "Understanding Privacy," is blank.

Comment 1

[Mike Pinkerton (not reading bugmail)]

how very strange. at least the item doesn't do anything ;)

Comment 2

[Steve Dagley]

Changing milestone to 0.9.5 - please don't shoot me pink :-)

Comment 3

[Blake Ross]

It's Net2Phone.

Comment 4

[Mike Pinkerton (not reading bugmail)]

blake sees this on win32 as well, so it's xp.

Comment 5

[sairuh (rarely reading bugmail)]

hm, methinks he might be seeing http://bugscape.mcom.com/show_bug.cgi?id=8665.

or, rather might this be a dup of that? strange, though --i wouldn't think this
would crop up on a mozilla build...

Comment 6

[sairuh (rarely reading bugmail)]

cc'ing pchen, since he's assigned to the bugscape item.

Comment 7

[Blake Ross]

worksforme.

Comment 8

[J Luh]

The blank menu item is still there in Mac OS X build 2001101809.

Comment 9

[Blake Ross]

mac only then, --> pchen

Comment 10

[J Luh]

The blank menu item appears because the "display:none" doesn't work in 

http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/tasksOverlay.xul#53

<menupopup  id="personalManagers">
<menuitem id="lastInPersonalManagers" style="display:none;"/>
</menupopup>

Comment 11

[Paul Chen]

This happens under 2001-10-29 OS X build and not under 2001-10-22 OS 9 build.
->pinkerton since he's the macos x man ;-)

Comment 12

[Mike Pinkerton (not reading bugmail)]

uh, from the last comment, this is a xul bug. they're trying to hide with
display:none, which doesn't work on mac (all menus are display: none on mac). it
needs to have the 'hidden' or 'collapsed' attributes set instead.

back to apps

Comment 13

[Blake Ross]

Round and round we go. Okay, so there's a proposed fix but I can't test it. -->pchen

Comment 14

[Peter Trudelle]

->bryner

Comment 15

[Brian Ryner (not reading)]

Attachment: patch

This seems to work.

Comment 16

[J Luh]

The patch works on my setup.

Comment 17

[Simon Fraser [no longer active]]

Comment on attachment 63615 [details] [diff] [review]
patch

sr=sfraser

Comment 18

[[e-mail] (gone - use [e-mail] instead)]

Comment on attachment 63615 [details] [diff] [review]
patch

r=stephend

Comment 19

[Brian Ryner (not reading)]

checked in

Comment 20

[sairuh (rarely reading bugmail)]

verified fixed using 2002.01.29.11 comm verif bits on mac 10.1.2.