902550 - Disable more session restore code in e10s

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: sessionrestore-fix

Session restore is supposed to be completely disabled on mozilla-central when browser.tabs.remote is set. However, it looks like we can still call the onLoad function, which can cause problems. This patch adds another test to avoid this.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 787023 [details] [diff] [review]
sessionrestore-fix

Review of attachment 787023 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/sessionstore/src/SessionStore.jsm
@@ +393,5 @@
>  
> +    if (this._disabledForMultiProcess) {
> +      this._deferredInitialized.resolve();
> +      return;
> +    }

I think we should bail out earlier, before observers are added. Otherwise we'll end up tracking windows when they're opened etc.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: sessionrestore-fix v2

This should skip the observers.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: sessionrestore-fix v3

Tom noticed a couple paths through the API that need fixing.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb7bf75e0a28

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/eb7bf75e0a28

Comment 6

[tabmix.onemen]

(In reply to Bill McCloskey (:billm) from comment #0)
> Session restore is supposed to be completely disabled on mozilla-central
> when browser.tabs.remote is set.

What about all other public functions?
HistoryMenu calls: getClosedTabCount, getClosedTabData, getClosedWindowCount, getClosedWindowData

duplicateTabIn call duplicateTab

is it permanent disabled or just until Session restore will be e10s ready?