Improve CSS on show_bug for the Sandstone skin

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Sandstone/Mozilla Skin
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lizzard, Assigned: lizzard)

Tracking

Production
x86
Mac OS X

Details

Attachments

(2 attachments, 3 obsolete attachments)

- labels on show_bug are mixed bold/normal
- remove the background from the user on show_bug for comments/changes (the user shouldn't be the most highlighted item on the page)
- 'last comment' is massive.  massive.
- for change-only, the change author should be styled the same as with-comment changes
- comments should be wider
(Assignee)

Comment 1

5 years ago
Created attachment 787076 [details] [diff] [review]
Fixes in global.css for sandsone.

Makes comment box wider, makes the field header fonts consistent weights, and makes the commenter names consistent and a bit de-emphasized.
Attachment #787076 - Flags: review?(glob)
(Assignee)

Comment 2

5 years ago
Created attachment 787094 [details] [diff] [review]
Added two more tweaks to the patch

Removed indentation for commenter names and set the field names to nowrap.
Attachment #787076 - Attachment is obsolete: true
Attachment #787076 - Flags: review?(glob)
Attachment #787094 - Flags: review?(glob)
Comment on attachment 787094 [details] [diff] [review]
Added two more tweaks to the patch

> Removed indentation for commenter names

this doesn't appear to have been addressed - there's still a left margin on the bz_comment_user elements.
Attachment #787094 - Flags: review?(glob) → review-
Assignee: nobody → lhenry
(Assignee)

Comment 4

5 years ago
Created attachment 787689 [details] [diff] [review]
sandstone_bug_1.patch

This should have all the changes mentioned in comments above. The commenter names are now lined up with the comment body text; thus they are indented a little from the white background for the comment.
Attachment #787094 - Attachment is obsolete: true
Attachment #787689 - Flags: review?(glob)
Comment on attachment 787689 [details] [diff] [review]
sandstone_bug_1.patch

you forgot to include the patch to inlinehistory which adds the ih_history_change container.
Attachment #787689 - Flags: review?(glob) → review-
Created attachment 788202 [details]
Screen Shot 2013-08-09 at 8.55.46 AM.png

the alignment's slightly off too.
(Assignee)

Comment 7

5 years ago
Created attachment 788279 [details] [diff] [review]
902590_2.patch

Makes style for standalone inline history changes consistent with inline history changes that are attached to comments.
Attachment #787689 - Attachment is obsolete: true
Attachment #788279 - Flags: review?(glob)
Comment on attachment 788279 [details] [diff] [review]
902590_2.patch

r=glob much nicer :)
Attachment #788279 - Flags: review?(glob) → review+
thanks liz!

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/InlineHistory/web/inline-history.js
modified skins/contrib/Mozilla/global.css
Committed revision 8929.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

5 years ago
thanks for setting me up with bugzilla-dev-manager, glob!
You need to log in before you can comment on or make changes to this bug.