Closed Bug 902590 Opened 6 years ago Closed 6 years ago

Improve CSS on show_bug for the Sandstone skin

Categories

(bugzilla.mozilla.org Graveyard :: Sandstone/Mozilla Skin, defect)

Production
x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lizzard, Assigned: lizzard)

References

Details

Attachments

(2 files, 3 obsolete files)

- labels on show_bug are mixed bold/normal
- remove the background from the user on show_bug for comments/changes (the user shouldn't be the most highlighted item on the page)
- 'last comment' is massive.  massive.
- for change-only, the change author should be styled the same as with-comment changes
- comments should be wider
Makes comment box wider, makes the field header fonts consistent weights, and makes the commenter names consistent and a bit de-emphasized.
Attachment #787076 - Flags: review?(glob)
Removed indentation for commenter names and set the field names to nowrap.
Attachment #787076 - Attachment is obsolete: true
Attachment #787076 - Flags: review?(glob)
Attachment #787094 - Flags: review?(glob)
Comment on attachment 787094 [details] [diff] [review]
Added two more tweaks to the patch

> Removed indentation for commenter names

this doesn't appear to have been addressed - there's still a left margin on the bz_comment_user elements.
Attachment #787094 - Flags: review?(glob) → review-
Assignee: nobody → lhenry
Attached patch sandstone_bug_1.patch (obsolete) — Splinter Review
This should have all the changes mentioned in comments above. The commenter names are now lined up with the comment body text; thus they are indented a little from the white background for the comment.
Attachment #787094 - Attachment is obsolete: true
Attachment #787689 - Flags: review?(glob)
Comment on attachment 787689 [details] [diff] [review]
sandstone_bug_1.patch

you forgot to include the patch to inlinehistory which adds the ih_history_change container.
Attachment #787689 - Flags: review?(glob) → review-
the alignment's slightly off too.
Attached patch 902590_2.patchSplinter Review
Makes style for standalone inline history changes consistent with inline history changes that are attached to comments.
Attachment #787689 - Attachment is obsolete: true
Attachment #788279 - Flags: review?(glob)
Comment on attachment 788279 [details] [diff] [review]
902590_2.patch

r=glob much nicer :)
Attachment #788279 - Flags: review?(glob) → review+
thanks liz!

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/InlineHistory/web/inline-history.js
modified skins/contrib/Mozilla/global.css
Committed revision 8929.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
thanks for setting me up with bugzilla-dev-manager, glob!
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.