Closed Bug 90263 Opened 20 years ago Closed 9 years ago

New account wizard uses "server name" and "hostname"

Categories

(MailNews Core :: Account Manager, defect)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 13.0

People

(Reporter: dsmutil, Assigned: aceman)

References

()

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.2) Gecko/20010628
BuildID:    2001062815

When a new mail account is created and one of the POP3/IMAP and SMTP server host
names is left blank, an alert "Please enter a valid hostname." is displayed. The
fields in the form are labeled "Server Name." The names should match.

Is this test even necessary? The account could only be used for sending (e.g., I
use the browser occasionally to send but have my work address and the e-mail
address. I don't retrieve mail from it) or receiving. Most people would set up
both servers but, if one is blank, just don't check mail/allow creation.

Reproducible: Always
Steps to Reproduce:
1.In a new profile, go to e-mail.
2.Select ISP, type in your name, etc., and go forward 2x.
3.

Also, if you go back to the "ISP or Newsgroup" selection, anything that was set
is lost.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Hardware: PC → All
I think `server name' is the more understandable of the two by a considerable 
margin.
Taking. What I'll also do is have the first input field which requires a server
name but doesn't yet have one, focused and ready for typing into. This saves the
user wondering which field the dialog is complaining about (it may not be obvious).

On the point about whether these checks are necessary, I'd say they were, at
least until we have sufficient time to code a run-time checking of such servers
when we want to read/send mail and prompt for server names if we don't have them.
Assignee: racham → jg
Keywords: polish
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla0.9.7
Also, it requires a server _NAME_ and won't accept an IP number (in 0.9.7/linux,
build id 2001122108). Why? You don't always have "host names", or at least
not always ones that are easier to type than are their numeric counterparts.
The Target Milestone (0.9.7) is passed.  This bug should be retargeted.
If you are no longer interested or able to work on this bug, please reset
the Target Milestone and hand it back to default owner of the component.
Bouncing out, hope someone with more time than I catches.
Assignee: jg → racham
Status: ASSIGNED → NEW
Is all this bug needs is the word hostname changed to server name?
If thats the case, I just did a quick patch that does this.  I'll attach it so
you can see what I've done.
Here is the quick patch I made.  All it does is change hostname to server name
in the files that basic found minus the addressbook one.  The addressbook one
can be added if you want.
Yes, that's all that's needed unless it would be better to change the
functionality so a receive-only (or send-only with a reply-to) configuration is
possible.
I'm not quite sure what you mean by "receive-only (or send-only with a reply-to)
configuration".  However, no matter what it is, my limited programming knowledge
probably won't be able to do something like that.  As well, it sounds like it
changes the behaviour of the wizard, which means it should be a different bug.
Right now the wizard REQUIRES an entry for Incoming Server and Outgoing Server.
Although most users will have an entry for both of these, it's not really required. 

Examples:
If someone leaves the Incoming Server field blank then they will only be able to
send mail from the client. An example would be a webmail user. They can send
e-mail using the proper return address but won't be able to retrieve their mail
using IMAP or POP.
If someone leaves the Outgoing Server blank then they won't be able to send
mail. This could be used just to look at mail in an IMAP mailbox or to retrieve
messages (e.g., cron e-mails) from a receive-only mailbox.

I propose dropping the check altogether and verify that the mail client does
something smart if the field is blank.
Keywords: mozilla1.0
Target Milestone: mozilla0.9.7 → ---
FYI: If the proposal in comment 11 is adopted, I think that should fix Bug
159700 as well.
mass re-assign.
Assignee: racham → sspitzer
Comment on attachment 106602 [details] [diff] [review]
quick patch that changes hostname to server name

This should change the "hostname" to "server name" which is the original issue
in this bug report.
Attachment #106602 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #106602 - Flags: review?(neil.parkwaycc.co.uk) → review+
Comment on attachment 106602 [details] [diff] [review]
quick patch that changes hostname to server name

review please
Attachment #106602 - Flags: superreview?(mscott)
Attachment #106602 - Flags: superreview?(mscott) → superreview+
Product: Browser → Seamonkey
Assignee: sspitzer → mail
Priority: P1 → --
QA Contact: nbaca
This patch has r+ and sr+, however there doesn't seem to be any indication that it was ever checked in. Looking at MXR, both SeaMonkey and Thunderbird still have the "Please enter a valid hostname" wording in various locations.
(In reply to comment #16)
> This patch has r+ and sr+, however there doesn't seem to be any indication that
> it was ever checked in. Looking at MXR, both SeaMonkey and Thunderbird still
> have the "Please enter a valid hostname" wording in various locations.

The patch is at least incorrect now. The string names should be changing to alter localisers to the change in context.
QA Contact: mailnews-account
Whiteboard: [has draft patch]
Instead of arguing about whether it should be one or the other, why not:

"Server hostname"
That sounds a bit redundant as server=host, and "server name" was already approved. There are also similar occurrences in the shared address book,
which could be changed to "server name" then as well.

I'm adding the MXR query for that string and move this bug to MailNews Core.
Assignee: mail → nobody
Component: MailNews: Account Configuration → Account Manager
Product: SeaMonkey → MailNews Core
QA Contact: mailnews-account → account-manager
Whiteboard: [has draft patch] → [needs new patch]
This also happens in the Account manager-> SMTP server name.
I'll update the patch.
Assignee: nobody → acelists
Whiteboard: [needs new patch]
I think the mxr search is bogus. The other places where "hostname" is referenced in an error message use the term "web site" (cookie manager) and "hostname" (LDAP addressbook) in the corresponding form field. So there is no point in changing the error text to "server name" in them.
I attach updated patch that only fixes the account manager.
Attachment #106602 - Attachment is obsolete: true
Attachment #596393 - Flags: review?(mbanner)
Attachment #596393 - Flags: review?(iann_bugzilla)
Attachment #596393 - Flags: review?(iann_bugzilla) → review+
Status: NEW → ASSIGNED
(In reply to :aceman from comment #21)
> I think the mxr search is bogus. The other places where "hostname" is
> referenced in an error message use the term "web site" (cookie manager) and
> "hostname" (LDAP addressbook) in the corresponding form field. So there is
> no point in changing the error text to "server name" in them.

So technically the cookie manager should also be fixed from calling "hostname" in the error message. But it should be another bug and it probably is in the Firefox/Toolkit.
Anybody interested in filing it?
Attachment #596393 - Flags: review?(mbanner) → review+
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/59710ebe215a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.