Closed Bug 902631 Opened 12 years ago Closed 7 years ago

check_head_headers.sh requires current branch to be rebased onto develop to work properly

Categories

(Android Background Services Graveyard :: Build & Test, defect)

Product:
Android Background Services Graveyard
Component:
Build & Test
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: mcomella, Unassigned)

Details

The command, "git diff --name-only develop HEAD ..." in check_head_headers.sh assumes the current branch is rebased onto develop, which is not always desirable as it may overwrite review comments on github. Assuming this script is used for each commit, "git diff --name-only HEAD^ ..." should probably suffice. Workaround: move the local develop branch to the appropriate location at the diverging point of the current branch.
Don't use these scripts anymore.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.