ClippedImageCachedSurface::Surface() calls GetThebesSurfaceForDrawTarget() which causes a flush on D2D

RESOLVED WORKSFORME

Status

()

Core
ImageLib
RESOLVED WORKSFORME
5 years ago
2 years ago

People

(Reporter: vladan, Assigned: seth)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P?][Australis:M-])

(Reporter)

Description

5 years ago
This happens during the tab animation tests:

http://people.mozilla.com/~bgirard/cleopatra/#report=50554cfc110c7d3a15a872283d7ab40f69129a55

We should avoid this by either not hitting this code path with the theme or preferably fixing the code path.
Whiteboard: [Australis:P?][Australis:M?]
Whiteboard: [Australis:P?][Australis:M?] → [Australis:P5][Australis:M?]
(Assignee)

Updated

5 years ago
Assignee: nobody → seth
(Assignee)

Comment 1

5 years ago
Do we still hit this on the current version of Australis?

This will be fixed by the Moz2dification of imagelib. I can push on it harder if it's still a problem for Australis.
Flags: needinfo?(mnoorenberghe+bmo)
Whiteboard: [Australis:P5][Australis:M?] → [Australis:P?][Australis:M?]
Sorry, I don't really have time to test this anytime soon. Vladan, can you check?
Flags: needinfo?(MattN+bmo) → needinfo?(vdjeric)
Whiteboard: [Australis:P?][Australis:M?] → [Australis:P?][Australis:M-]
(Reporter)

Comment 3

5 years ago
Tested with TART v1.5 and Australis Nightly 2013-11-28:

http://people.mozilla.org/~bgirard/cleopatra/#report=7e527836e86b83d806cc6d0f8dccbcabc90a87c5

I don't see calls to GetThebesSurfaceForDrawTarget anymore
Flags: needinfo?(vdjeric)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.