Localise emails sent from the Reviewer Tools

RESOLVED WONTFIX

Status

Marketplace
Reviewer Tools
RESOLVED WONTFIX
5 years ago
5 years ago

People

(Reporter: cvan, Unassigned)

Tracking

Points:
---

Details

(Reporter)

Description

5 years ago
Now that we're saving the most recently used locale for each user, let's localise our emails, such as this one:

    https://github.com/mozilla/zamboni/blob/master/mkt/reviewers/templates/reviewers/emails/decisions/pending_to_public.txt

Bug 879535 adds yet another email for developer<->reviewer communication. Let's localise these once and for all!

This means preparing each subject+template separately and sending each mail message separately. UserProfile.activate_lang() will probably come in handy:

    https://github.com/mozilla/zamboni/blob/1d834f49d/apps/users/models.py#L486
I'm against this.  All of the actual review content is always written in English so localising the text that wraps around it would look strange.  It could also potentially be counter productive - i.e. the developer only reads the part in their language and ignores the rest figuring its not important or a duplicate in English.

If at some future point we do have multilingual reviews we can re-open.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.