902732 - Drop nsILink from non-<link> elements

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Merge nsILink and dom::Link r=bz

Comment 2

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Comment on attachment 787258 [details] [diff] [review]
Merge nsILink and dom::Link r=bz

How about we nuke LinkAdded/LinkRemoved off everything that's not HTMLLinkElement altogether, and make the ones on HTMLLinkElement non-virtual.  Then we change this bit in nsDocument:

  nsRefPtr<nsContentList> links = NS_GetContentList(root,
                                                    kNameSpaceID_Unknown,
                                                    NS_LITERAL_STRING("link"));

to pass kNameSpaceID_HTML and then we can just static_cast the list elements to HTMLLinkElement.  Do that in both pageshow and pagehide.

The rest looks good.

Comment 3

[David Zbarsky (:dzbarsky)]

Attachment: Merge nsILink and dom::Link r=bz

Comment 4

[David Zbarsky (:dzbarsky)]

Attachment: Merge nsILink and dom::Link r=bz

Comment 5

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Comment on attachment 787343 [details] [diff] [review]
Merge nsILink and dom::Link r=bz

r=me

Comment 6

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e76495237e88

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e76495237e88

Comment 9

[:ehsan akhgari]

Andrea, this could probably bitrot your patches for the URL API.

Comment 10

[Andrea Marchesini [:baku]]

Ehsan, I updated my patch for URL API, can you take a look and see if this patch changes something for it?

Comment 11

[:ehsan akhgari]

(In reply to Andrea Marchesini (:baku) from comment #10)
> Ehsan, I updated my patch for URL API, can you take a look and see if this
> patch changes something for it?

It shouldn't change anything fundamental, I mostly CCed you here in case your patches failed to apply on top of this.  Otherwise, no need to worry about anything here!