Closed
Bug 902732
Opened 8 years ago
Closed 8 years ago
Drop nsILink from non-<link> elements
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: dzbarsky, Assigned: dzbarsky)
References
Details
Attachments
(1 file, 2 obsolete files)
29.78 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #787258 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
![]() |
||
Comment 2•8 years ago
|
||
Comment on attachment 787258 [details] [diff] [review] Merge nsILink and dom::Link r=bz How about we nuke LinkAdded/LinkRemoved off everything that's not HTMLLinkElement altogether, and make the ones on HTMLLinkElement non-virtual. Then we change this bit in nsDocument: nsRefPtr<nsContentList> links = NS_GetContentList(root, kNameSpaceID_Unknown, NS_LITERAL_STRING("link")); to pass kNameSpaceID_HTML and then we can just static_cast the list elements to HTMLLinkElement. Do that in both pageshow and pagehide. The rest looks good.
Attachment #787258 -
Flags: review?(bzbarsky)
Attachment #787258 -
Flags: review-
Attachment #787258 -
Flags: feedback+
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #787258 -
Attachment is obsolete: true
Attachment #787341 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #787341 -
Attachment is obsolete: true
Attachment #787341 -
Flags: review?(bzbarsky)
Attachment #787343 -
Flags: review?(bzbarsky)
![]() |
||
Comment 5•8 years ago
|
||
Comment on attachment 787343 [details] [diff] [review] Merge nsILink and dom::Link r=bz r=me
Attachment #787343 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e76495237e88
Updated•8 years ago
|
Summary: Merge nsILink and dom::Link → Drop nsILink from non-<link> elements
Comment 8•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e76495237e88
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Comment 9•8 years ago
|
||
Andrea, this could probably bitrot your patches for the URL API.
Comment 10•8 years ago
|
||
Ehsan, I updated my patch for URL API, can you take a look and see if this patch changes something for it?
Comment 11•8 years ago
|
||
(In reply to Andrea Marchesini (:baku) from comment #10) > Ehsan, I updated my patch for URL API, can you take a look and see if this > patch changes something for it? It shouldn't change anything fundamental, I mostly CCed you here in case your patches failed to apply on top of this. Otherwise, no need to worry about anything here!
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•