902769 - B2G RIL : SIM PIN toggle does not work on Nexus 4( JB, Android-4.3)

Status: RESOLVED FIXED

Description

[shawn ku [:sku]]

Attachment: radio.log

Symptom:
  SIM PIN toggle does not work on Nexus4 (Android 4.3)

Steps:
  1. Go to "Settings" -> "SIM security"
  2. Check SIM PIN is on
  3. click on "SIM PIN" item 
  4. enter correct PIN to diable SIM PIN

Result:
  SIM PIN did not diabled.

Expected Result:
  SIM PIN can be toggled successfully.

Note:
  Same result from MMI request **04*OLD_PIN*NEW_PIN*NEW_PIN#

Log Analysis:
08-08 10:06:02.325   178   178 I Gecko   : -*- RadioInterfaceLayer: Received 'RIL:SetCardLock' message from content process
08-08 10:06:02.325   178   507 I Gecko   : RIL Worker[0]: Received chrome message {"lockType":"pin","pin":"0000","enabled":true,"requestId":"id{58fe4003-7e0a-45b5-98bd-3f38fd76ea13}","rilMessageType":"iccSetCardLock"}
08-08 10:06:02.335   178   507 I Gecko   : RIL Worker[0]: Solicited response for request type 43, token 96, error 6
08-08 10:06:02.335   178   507 I Gecko   : RIL Worker[0]: Handling parcel as REQUEST_SET_FACILITY_LOCK
08-08 10:06:02.335   178   178 I Gecko   : -*- RadioInterface[0]: Received message from worker: {"lockType":"pin","pin":"0000","enabled":true,"requestId":"id{58fe4003-7e0a-45b5-98bd-3f38fd76ea13}","rilMessageType":"iccSetCardLock","facility":"SC","password":"0000","serviceClass":7,"rilRequestType":43,"rilRequestError":6,"success":false,"errorMsg":"RequestNotSupported","retryCount":-1}
08-08 10:06:02.405   178   507 I Gecko   : RIL Worker[0]: Received chrome message {"lockType":"pin","requestId":"id{446cfd2a-ad31-44a9-b4c1-54ea19f8790c}","rilMessageType":"iccGetCardLockState"}

Comment 1

[shawn ku [:sku]]

Correct some typo on detail description.

Symptom:
  SIM PIN toggle does not work on Nexus4 (Android 4.3)

Steps:
  1. Go to "Settings" -> "SIM security"
  2. Check SIM PIN is on
  3. click on "SIM PIN" item 
  4. enter correct PIN to disable SIM PIN

Result:
  SIM PIN did not disabled.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

Start from line 1141, I saw some assertion from modem then the SET_FACILITY_LOCK returns REQUEST_NOT_SUPPORTED.

Comment 3

[shawn ku [:sku]]

Pure AOSP 4.3 on Nexus4 works okay.

08-08 11:59:55.956   826   826 D RILJ    : [0166]> SET_FACILITY_LOCK [SC false 7 a0000000871002ff33ff0189060500ff]
08-08 11:59:56.017   826   897 D RILJ    : [0166]< SET_FACILITY_LOCK {0}
08-08 11:59:56.037   826   826 D UiccCardApplication: EVENT_CHANGE_FACILITY_LOCK_DONE: mIccLockEnabled= false
08-08 11:59:59.130   826   826 D RILJ    : [0168]> SET_FACILITY_LOCK [SC true 7 a0000000871002ff33ff0189060500ff]
08-08 11:59:59.190   826   897 D RILJ    : [0168]< SET_FACILITY_LOCK {0}
08-08 11:59:59.200   826   826 D UiccCardApplication: EVENT_CHANGE_FACILITY_LOCK_DONE: mIccLockEnabled= true

Comment 4

[shawn ku [:sku]]

Attachment: AOSP_nexus4.log

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

Attachment: Part 1 : Patch

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

Attachment: Part 2: xpcshell test

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

Attachment: Part 2: xpcshell tests for facility lock v2

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 787396 [details] [diff] [review]
Part 1 : Patch

Review of attachment 787396 [details] [diff] [review]:
-----------------------------------------------------------------

Confirmed in AOSP GB source[1].  ICS/JB has the same parcel data layout.

[1]: http://androidxref.com/2.3.6/xref/frameworks/base/telephony/java/com/android/internal/telephony/RIL.java#1653

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

Try result
https://tbpl.mozilla.org/?tree=Try&rev=f534aacaeec5

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3690b7c80bb0
https://hg.mozilla.org/integration/b2g-inbound/rev/613a15b5256f

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3690b7c80bb0
https://hg.mozilla.org/mozilla-central/rev/613a15b5256f