902834 - Implement hack and merge australis branch with master

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1154

Pointer to Github pull-request

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 787378 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1154

Irakli, can you take a look at the comments Matteo made and tell me if you think they are necessary please?

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Matteo can you please +/- this and tell me what the blockers are either way?..

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

You've made a bunch of comments in the pull request, most of which I've argued against and you've said are non blockers, but you have not said what are blockers nor have to r+'d or r-'d this yet, so I don't see what it is you expect from me..

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

Sorry Erik, you're totally right, I wasn't clear about that. Now that you open the other bug, the main blocker to me is a clear message to the developer about "Unsupported Application", at least I'd like to add the module.id as I wrote in my last comment: https://github.com/mozilla/addon-sdk/pull/1154#issuecomment-22377892

In order to merge with master, I'd like also to fix the '> 24' (see comment https://github.com/erikvold/addon-sdk/commit/81520cf6f0d650be6279ede789b302e537bc3d56#commitcomment-3832051 about why), but if you're totally against that I do not want to force you, we can update / remove also once landed.

With those is r+; I didn't set any flag yet because I was trying to resolve the arguing about our discussion before.

Thanks, and sorry for the misleading!

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1157

Pointer to Github pull-request

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 788767 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1157

Matteo I added the `module.id` as that was the only blocker that you mentioned, the rest of the suggestions should be done in another bug imo.

Comment 8

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #7)
> Comment on attachment 788767 [details]
> Pointer to Github pull request:
> https://github.com/mozilla/addon-sdk/pull/1157
> 
> Matteo I added the `module.id` as that was the only blocker that you
> mentioned, the rest of the suggestions should be done in another bug imo.

If at all.

Comment 9

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1158

Pointer to Github pull-request

Comment 10

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1159

Pointer to Github pull-request

Comment 11

[Erik Vold [:erikvold] (please needinfo? me)]

Sorry for the spam, reverting https://github.com/mozilla/addon-sdk/commit/db5fa2a4846c85ae1ebe4313c5672b2ba51b8814 triggered a bug in the Github network graph which made me think I was messing up my branches somehow (it looked like I was merging previous versions of the branch in to the new versions), but I was not and it took me awhile to realize it was a only bug in the network graph..

Comment 12

[Matteo Ferretti [:zer0] [:matteo]]

Not sure why https://github.com/mozilla/addon-sdk/commit/db5fa2a4846c85ae1ebe4313c5672b2ba51b8814 has to be reverted? It should be kept, unless I'm missing something.

Comment 13

[Matteo Ferretti [:zer0] [:matteo]]

r+, but I'd like to know why you had to revert that commit.

Comment 14

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Matteo Ferretti [:matteo] [:zer0] from comment #12)
> Not sure why
> https://github.com/mozilla/addon-sdk/commit/
> db5fa2a4846c85ae1ebe4313c5672b2ba51b8814 has to be reverted? It should be
> kept, unless I'm missing something.

Just to keep the blame clean https://github.com/mozilla/addon-sdk/pull/1141#issuecomment-21883068

Comment 15

[Jared Wein [:jaws] (please needinfo? me)]

Matteo, is this waiting for Australis to merge in to mozilla-central?

Comment 16

[Matteo Ferretti [:zer0] [:matteo]]

Jared, actually this bug was intended to merge the SDK australis branch (a branch of SDK that worked only in Australis) with our master, and makes sure that the Firefox Australis specific part didn't break the SDK on regular Firefox.

So, in short, no, this bug is not waiting for Australis, I thought actually that was marked as fixed once Erik landed the patch. I will do it now: Erik, if you know any reasons to keep it open, pleas reopen it.