Closed Bug 90284 Opened 25 years ago Closed 24 years ago

Remove installer checkbox for "Use this theme" to prevent dynamic skin switch

Categories

(Core Graveyard :: Skinability, defect)

Product:
Core Graveyard
Component:
Skinability
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: hewitt, Assigned: hewitt)

Details

(Whiteboard: PDT+)

Attachments

(1 file)

patch to fix
1.23 KB, patch
Details | Diff | Splinter Review
The theme install dialog prompts the user to use the theme after installing it. We should disable this on the branch to prevent a dynamic theme switch.
Status: NEW → ASSIGNED
Keywords: nsBranch
Attached patch patch to fix — — Splinter Review
r=syd
sr=mscott
PDT+ per email to PDT. Pls check into the branch as soon as you are able to. Thanks.
Whiteboard: [PDT+]
fixed on branch
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Verified on the branch build (2001-07-18-03-0.9.2)
Status: RESOLVED → VERIFIED
reopening for the trunk. Hyatt, can I land this fix on the trunk for 0.9.4?
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
nsbranch+ per pdt triage
Keywords: nsbranch → nsbranch+
why didn't it go on the trunk earlier?
removing PDT+ as it was for o.9.2 branch (you need to get approval again for 0.9.4, since this wasn't checked in on the trunk earlier)
Whiteboard: [PDT+]
lets get this on the branch. is it ready to go? can it happen today?
the patch from 7/10 is still valid, I can land it today.
Status: REOPENED → ASSIGNED
Adding PDT to status whiteboard, need to get this on the branch today or tomorrow according to mcarlson.
Whiteboard: PDT
Yes, please check this change into the branch by tomorrow 9/25 for 110n approval. thanks
How about it PDT? We really don't want to allow users to install themes straight form the download, they will run into a lot of very bad problems potentially. Sounds like Joe's saying it is the same patch, so the r and sr should still be good.
This needs reviews before we can + it
Joe, I just talked to Jaime and he said that the original reviews are okay, just update the bug to reflect that it has r and sr and PDT will plus it. Thanks.
This bug is r=syd, sr=mscott
check it in now - PDT+
Whiteboard: PDT → PDT+
checked into branch
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 24 years ago
Resolution: --- → FIXED
Verified on all platform (branch build: 2001-10-01-05-0.9.4).
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: