902935 - Error smiley is not aligned properly when smaller images are uploaded

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Developer Pages, defect, P5)

Description

[Iulian Timis]

Attachment: smiley_error.png

Steps to reproduce:
1. Load My Submissions page https://marketplace-dev.allizom.org/developers/submissions
2. Go to Edit Listing page for a submitted app.
3. Upload a screenshot smaller than 320px by 480px or 480px by 320px.

Expected results:
There are no design or layout issues.

Actual results:
The smiley icon within the uploaded screenshot thumbnail is aligned to the center of it.

Notes/Issues:
Verified on FF26 (Win 7).
Attaching screenshot for this issue.

Comment 1

[Matt Basta [:basta]]

That's probably the least of the issues for the screenshot upload. We just need to rip that thing out and try again.

Comment 2

[Matt Basta [:basta]]

Resolving as WONTFIX since this is going away when bug 900296 lands.

The issue here is that we're using a unicode glyph for the smiley, and the font size is bigger than the image. Even if we reduced the size of the font, you could upload a "shorter" screenshot and cause the same issue again.

Even if we managed to vertically center the smiley over the image, it would still look dumb since it would hang off the sides. We could clip it, but then it would look even dumber because you wouldn't be able to tell it's a smiley.