902938 - add Services.androidBridge and use it in Fennec code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: add androidBridge to Services.jsm

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: update android code to use Services.androidBridge

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 787582 [details] [diff] [review]
update android code to use Services.androidBridge

>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js

>-function getBridge() {
>-  return Cc["@mozilla.org/android/bridge;1"].getService(Ci.nsIAndroidBridge);
>+  Services.console.logStringMessage(a);
> }

getBridge is going away, rightly so, but getBridge is called a few times in browser.js:

http://mxr.mozilla.org/mozilla-central/search?string=getBridge&find=mobile/android

Those should be changed to Services.androidBridge

r+ with those changes

Off-topic:
Services.androidBridge.handleGeckoMessage would be nicer as Servcies.androidBridge.sendMessage, but that is a different but for the future.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 787581 [details] [diff] [review]
add androidBridge to Services.jsm

Review of attachment 787581 [details] [diff] [review]:
-----------------------------------------------------------------

Update the test please

Comment 5

[Nathan Froyd [:froydnj]]

Attachment: add androidBridge to Services.jsm

Updated test.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b9d7a5c2706
https://hg.mozilla.org/mozilla-central/rev/8348bc72f298