Closed Bug 902938 Opened 6 years ago Closed 6 years ago

add Services.androidBridge and use it in Fennec code

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 26

People

(Reporter: froydnj, Unassigned)

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
Attachment #787581 - Flags: review?(dtownsend+bugmail)
Comment on attachment 787582 [details] [diff] [review]
update android code to use Services.androidBridge

>diff --git a/mobile/android/chrome/content/browser.js b/mobile/android/chrome/content/browser.js

>-function getBridge() {
>-  return Cc["@mozilla.org/android/bridge;1"].getService(Ci.nsIAndroidBridge);
>+  Services.console.logStringMessage(a);
> }

getBridge is going away, rightly so, but getBridge is called a few times in browser.js:

http://mxr.mozilla.org/mozilla-central/search?string=getBridge&find=mobile/android

Those should be changed to Services.androidBridge

r+ with those changes

Off-topic:
Services.androidBridge.handleGeckoMessage would be nicer as Servcies.androidBridge.sendMessage, but that is a different but for the future.
Attachment #787582 - Flags: review?(mark.finkle) → review+
Comment on attachment 787581 [details] [diff] [review]
add androidBridge to Services.jsm

Review of attachment 787581 [details] [diff] [review]:
-----------------------------------------------------------------

Update the test please
Attachment #787581 - Flags: review?(dtownsend+bugmail) → review-
Updated test.
Attachment #787581 - Attachment is obsolete: true
Attachment #787826 - Flags: review?(dtownsend+bugmail)
Attachment #787826 - Flags: review?(dtownsend+bugmail) → review+
https://hg.mozilla.org/mozilla-central/rev/5b9d7a5c2706
https://hg.mozilla.org/mozilla-central/rev/8348bc72f298
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.