Closed Bug 903044 Opened 12 years ago Closed 12 years ago

Remove toolbar-menubar currentset from talos localstore.rdf's

Categories

(Testing :: Talos, defect)

x86_64
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(2 files)

The profile used by talos to run (at least) the tpaint and ts_paint tests has a currentset attribute set on the toolbar-menubar. Is this necessary? I was under the impression that these tests are supposed to (ideally) simulate Firefox running in its out-of-the-box state (so, no customizations). Can we remove this attribute?
Any objection to removing this attribute, Joel?
Flags: needinfo?(jmaher)
Something like this?
Assignee: nobody → mconley
Status: NEW → ASSIGNED
Attachment #787691 - Flags: review?(jmaher)
Comment on attachment 787691 [details] [diff] [review] Speculative Patch v1 Review of attachment 787691 [details] [diff] [review]: ----------------------------------------------------------------- this is great. I recall the need to add other information here instead of just removing these items. I worked with mattn a while back and realized that we should look at what a default profile has in localstore.rdf today to make it useful. For example, we have the places tests with prepopulated data, this doesn't make any sense because we don't have any default UI elements like toolbars visible that will even use the code path. We can do that as a follow up if wanted :)
Attachment #787691 - Flags: review?(jmaher) → review+
Flags: needinfo?(jmaher)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
So, how do I go about getting this change out to the talos bots? Or is this process automated?
Flags: needinfo?(jmaher)
please add your revision to here: http://mxr.mozilla.org/mozilla-central/source/testing/talos/talos.json#8 i.e.: - "talos_revision": "4063ef2a221e" + "talos_revision": "592a42000e98" and then land on inbound as you normally would. I would be happy to review this today! Likewise you can push to try with a patch if you have any concerns. For reference I started my investigation into this in June and pushed to try with similar changes with no issues- short story, I believe this is really safe.
Flags: needinfo?(jmaher)
Here we are.
Attachment #788179 - Flags: review?(jmaher)
Comment on attachment 788179 [details] [diff] [review] Update talos.json Review of attachment 788179 [details] [diff] [review]: ----------------------------------------------------------------- fantastic
Attachment #788179 - Flags: review?(jmaher) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: