903049 - [Browser] Top Sites are Blurry

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P1)

Description

[Eric Pang [:epang] UX]

The top sites on the starting browser page are blurry.  Is there anything that can be done to make them sharp?

Comment 2

[Eric Pang [:epang] UX]

Attachment: Browser - Top Sites.png

Pavel, I was referring to these.  Sorry I didn't attach a screen before.  Do you know if they will be fixed with the other bug?

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Oh I understand ...
no I don't other bug but these are screenshot and I thing they are made by the platform. Maybe we need to ask Ben?

Comment 4

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #3)
> Oh I understand ...
> no I don't other bug but these are screenshot and I thing they are made by
> the platform. Maybe we need to ask Ben?

Hi Ben, do you know if there's anything that we can do to help the blurriness of the top site screens on the browser start page?  Thanks!

Comment 5

[Eric Pang [:epang] UX]

adding status-b2g-v1.1hd:? flag

Comment 6

[Ben Francis [:benfrancis]]

We shouldn't be doing any scaling, we specify the size of the thumbnail we want in the getScreenshot method of the Browser API.

Dale, it seemed you might have an idea of what might be going on during triage?

Comment 7

[ffos-browser]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/55162828

Comment 8

[Wayne Chang [:wchang]]

Dale, you're probably the better assignee for this bug here?

Comment 9

[[e-mail]]

Generally we can take screenshot with 1.5*MAX_THUMBNAIL_WIDTH image and resize it to the origin MAX_THUMBNAIL_WIDTH. (not need because we use 'cover' in background-size)

We have to scale up the size because to show the same size (140px) in 1.5x pixel density device, we actually need (140*1.5 px) image to fill it. Or the image will be zoom out to show at the same size on screen.

Comment 10

[[e-mail]]

Attachment: pull request redirect to github

Comment 11

[[e-mail]]

Attachment: sharp topsite

screenshot after patched

Comment 12

[[e-mail]]

Attachment: sharp topsite

Comment 13

[Eric Pang [:epang] UX]

(In reply to Fred Lin [:gasolin] from comment #12)
> Created attachment 791176 [details]
> sharp topsite

This looks much better, thanks Fred for your work on this!

Comment 14

[Ben Francis [:benfrancis]]

Comment on attachment 791164 [details]
pull request redirect to github

Thanks for the patch

Comment 15

[Ben Francis [:benfrancis]]

I can't test this without an HD device (it will have no effect on Unagi where pixel ratio is 1), but the code looks good.

https://github.com/mozilla-b2g/gaia/commit/4c57c9b72f0277b5d0d9e4a7c5a13ac1eb7a1732

Comment 16

[[e-mail]]

v1.1.0hd https://github.com/mozilla-b2g/gaia/commit/b99a607f0416882587c608182f2bf5af49fce48f

thanks

Comment 17

[William Hsu [:whsu]]

Well done! Thanks for your help! Verified the patch.

* Test build:(Mozilla Central-helix/2013-08-25-04-22-01)
  + Mercurial-Information
    - Gecko revision="f392714dea0b"
  + Git-information
    - Gaia revision="7b61b7dc3400d5bea23d2b52948f4fded8259dfc"


Attaching the screenshot. Marked as verified.

Comment 18

[William Hsu [:whsu]]

Attachment: Browser - Graph Rendering