Open Bug 903140 Opened 12 years ago Updated 3 years ago

Patching library functions multiple times with nsWindowsDllInterceptor is dangerous

Categories

(Toolkit :: Startup and Profile System, defect)

Product:
Toolkit
Component:
Startup and Profile System
Type:
defect

Tracking

()

People

(Reporter: vladan, Assigned: m_kato)

Details

It's unsafe to overwrite the prologue of a library call multiple times with nsWindowsDllInterceptor. We haven't see many crashes because we only intercept functions once, but 3rd party code could also start intercepting the functions we intercept.
Makoto, are you interested in this? I think for now we should just do a runtime abort if you try to hook the same function multiple times, because it's not clear what the required semantics are.
Component: General → Startup and Profile System
Product: Firefox → Toolkit
Assignee: nobody → m_kato
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.