Patching library functions multiple times with nsWindowsDllInterceptor is dangerous

NEW
Assigned to

Status

()

5 years ago
5 years ago

People

(Reporter: vladan, Assigned: m_kato)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
It's unsafe to overwrite the prologue of a library call multiple times with nsWindowsDllInterceptor. We haven't see many crashes because we only intercept functions once, but 3rd party code could also start intercepting the functions we intercept.

Comment 1

5 years ago
Makoto, are you interested in this?  I think for now we should just do a runtime abort if you try to hook the same function multiple times, because it's not clear what the required semantics are.
Component: General → Startup and Profile System
Product: Firefox → Toolkit
Assignee: nobody → m_kato
You need to log in before you can comment on or make changes to this bug.